Re: [Qemu-devel] [RFC PATCH] implement vmware pvscsi device

2011-04-18 Thread Paolo Bonzini
On 04/18/2011 04:05 PM, Hannes Reinecke wrote: My proposal would be to implement a full virtio-scsi _host_, and extend the proposal to be able to handle the transport layer too. Yes, I have added this independently from Friday to today, and it is why I haven't sent the proposal yet. At the

Re: [Qemu-devel] [RFC PATCH] implement vmware pvscsi device

2011-04-18 Thread Stefan Hajnoczi
On Mon, Apr 18, 2011 at 3:05 PM, Hannes Reinecke wrote: > On 04/15/2011 10:56 PM, Paolo Bonzini wrote: >> >> On 04/15/2011 05:04 PM, Stefan Hajnoczi wrote: >>> >>> The way I approached virtio-scsi was to look at the SCSI Architecture >>> Model document and some of the Linux SCSI code. I'm not sure

Re: [Qemu-devel] [RFC PATCH] implement vmware pvscsi device

2011-04-18 Thread Hannes Reinecke
On 04/15/2011 10:56 PM, Paolo Bonzini wrote: On 04/15/2011 05:04 PM, Stefan Hajnoczi wrote: The way I approached virtio-scsi was to look at the SCSI Architecture Model document and some of the Linux SCSI code. I'm not sure if letting virtio-blk SCSI pass-through or scsi-generic guide us is a goo

Re: [Qemu-devel] [RFC PATCH] implement vmware pvscsi device

2011-04-15 Thread Paolo Bonzini
On 04/15/2011 05:04 PM, Stefan Hajnoczi wrote: The way I approached virtio-scsi was to look at the SCSI Architecture Model document and some of the Linux SCSI code. I'm not sure if letting virtio-blk SCSI pass-through or scsi-generic guide us is a good approach. How do your ioprio and barrier r

Re: [Qemu-devel] [RFC PATCH] implement vmware pvscsi device

2011-04-15 Thread Stefan Hajnoczi
On Fri, Apr 15, 2011 at 3:37 PM, Paolo Bonzini wrote: > On 04/15/2011 04:28 PM, Stefan Hajnoczi wrote: >> Nothing formal.  I'm trying to learn SCSI as I go along: >> >> http://git.kernel.org/?p=linux/kernel/git/nab/lio-core-2.6.git;a=blob;f=include/linux/virtio_scsi.h;hb=refs/heads/tcm_vhost >> >>

Re: [Qemu-devel] [RFC PATCH] implement vmware pvscsi device

2011-04-15 Thread Paolo Bonzini
> Why vmw_pvscsi? Because all I wanted to do was to learn qemu's SCSI, and vmw_pvscsi is pretty much the simplest device I could pick... It's just an exercise, but since it works I thought I'd post it. > Good luck. Paul Brook absolutely insists on having them, but they kill > performance for any

Re: [Qemu-devel] [RFC PATCH] implement vmware pvscsi device

2011-04-15 Thread Hannes Reinecke
On 04/15/2011 04:17 PM, Paolo Bonzini wrote: > On 04/15/2011 04:01 PM, Stefan Hajnoczi wrote: >> I think SCSI brings many benefits. Guests can deal with it better >> than these alien vdX virtio-blk devices, which makes migration easier. >> It becomes possible to attach many disks without burning t

Re: [Qemu-devel] [RFC PATCH] implement vmware pvscsi device

2011-04-15 Thread Paolo Bonzini
On 04/15/2011 04:28 PM, Stefan Hajnoczi wrote: > Nothing formal. I'm trying to learn SCSI as I go along: > > http://git.kernel.org/?p=linux/kernel/git/nab/lio-core-2.6.git;a=blob;f=include/linux/virtio_scsi.h;hb=refs/heads/tcm_vhost > > That's the interface I'm using. Requests are: > > [Header

Re: [Qemu-devel] [RFC PATCH] implement vmware pvscsi device

2011-04-15 Thread Stefan Hajnoczi
On Fri, Apr 15, 2011 at 3:17 PM, Paolo Bonzini wrote: > On 04/15/2011 04:01 PM, Stefan Hajnoczi wrote: >> >> I think SCSI brings many benefits.  Guests can deal with it better >> than these alien vdX virtio-blk devices, which makes migration easier. >> It becomes possible to attach many disks with

Re: [Qemu-devel] [RFC PATCH] implement vmware pvscsi device

2011-04-15 Thread Paolo Bonzini
On 04/15/2011 04:01 PM, Stefan Hajnoczi wrote: I think SCSI brings many benefits. Guests can deal with it better than these alien vdX virtio-blk devices, which makes migration easier. It becomes possible to attach many disks without burning through free PCI slots. We don't need to update guests

Re: [Qemu-devel] [RFC PATCH] implement vmware pvscsi device

2011-04-15 Thread Stefan Hajnoczi
On Fri, Apr 15, 2011 at 2:42 PM, Paolo Bonzini wrote: > Lightly tested with Linux guests; at least it can successfully partition > and format a disk.  scsi-generic also lightly tested. > > Doesn't do migration, doesn't do hotplug (the device would support that, > but it is not 100% documented and

[Qemu-devel] [RFC PATCH] implement vmware pvscsi device

2011-04-15 Thread Paolo Bonzini
Lightly tested with Linux guests; at least it can successfully partition and format a disk. scsi-generic also lightly tested. Doesn't do migration, doesn't do hotplug (the device would support that, but it is not 100% documented and the Linux driver in particular cannot initiate hot-unplug). I d