Re: [Qemu-devel] [RFC PATCH] gdbstub: Avoid NULL dereference in gdb_handle_packet()

2019-02-02 Thread no-reply
Patchew URL: https://patchew.org/QEMU/20190118112213.11173-1-phi...@redhat.com/ Hi, This series failed the docker-mingw@fedora build test. Please find the testing commands and their output below. If you have Docker installed, you can probably reproduce it locally. === TEST SCRIPT BEGIN === #!

Re: [Qemu-devel] [RFC PATCH] gdbstub: Avoid NULL dereference in gdb_handle_packet()

2019-01-19 Thread Luc Michel
On 1/18/19 12:22 PM, Philippe Mathieu-Daudé wrote: > The "Hg" GDB packet is used to select the current thread, and can fail. > GDB doesn't not check for failure and emits further packets that can > access and dereference s->c_cpu or s->g_cpu. > > Add a check that returns "E22" (EINVAL) when those

[Qemu-devel] [RFC PATCH] gdbstub: Avoid NULL dereference in gdb_handle_packet()

2019-01-18 Thread Philippe Mathieu-Daudé
The "Hg" GDB packet is used to select the current thread, and can fail. GDB doesn't not check for failure and emits further packets that can access and dereference s->c_cpu or s->g_cpu. Add a check that returns "E22" (EINVAL) when those pointers are not set. Peter Maydell reported: GDB doesn't