Re: [Qemu-devel] [RFC PATCH] exec: Move hw_error() to the CPU namespace

2018-06-23 Thread Peter Maydell
On 22 June 2018 at 20:09, Thomas Huth wrote: > ... but I really wonder why this function got so popular in the hw/ > folder. Printing a dump of all CPU states does not make much sense in > most of the cases (which are really not directly related to CPU states). > So yes, we should try to slowly ge

Re: [Qemu-devel] [RFC PATCH] exec: Move hw_error() to the CPU namespace

2018-06-23 Thread no-reply
Hi, This series failed build test on s390x host. Please find the details below. Type: series Message-id: 20180622134610.23713-1-f4...@amsat.org Subject: [Qemu-devel] [RFC PATCH] exec: Move hw_error() to the CPU namespace === TEST SCRIPT BEGIN === #!/bin/bash # Testing script will be invoked

Re: [Qemu-devel] [RFC PATCH] exec: Move hw_error() to the CPU namespace

2018-06-22 Thread Thomas Huth
On 22.06.2018 16:32, Peter Maydell wrote: > On 22 June 2018 at 14:46, Philippe Mathieu-Daudé wrote: >> hw_error() is only meant for CPU errors (since it dumps the CPU state). > > I would disagree. hw_error() dumps the state of every CPU. The > corresponding function for CPU errors is cpu_abort(),

Re: [Qemu-devel] [RFC PATCH] exec: Move hw_error() to the CPU namespace

2018-06-22 Thread no-reply
Hi, This series failed docker-mingw@fedora build test. Please find the testing commands and their output below. If you have Docker installed, you can probably reproduce it locally. Type: series Message-id: 20180622134610.23713-1-f4...@amsat.org Subject: [Qemu-devel] [RFC PATCH] exec: Move

Re: [Qemu-devel] [RFC PATCH] exec: Move hw_error() to the CPU namespace

2018-06-22 Thread Peter Maydell
On 22 June 2018 at 14:46, Philippe Mathieu-Daudé wrote: > hw_error() is only meant for CPU errors (since it dumps the CPU state). I would disagree. hw_error() dumps the state of every CPU. The corresponding function for CPU errors is cpu_abort(), which dumps only the state of the relevant CPU. It

[Qemu-devel] [RFC PATCH] exec: Move hw_error() to the CPU namespace

2018-06-22 Thread Philippe Mathieu-Daudé
hw_error() is only meant for CPU errors (since it dumps the CPU state). Suggested-by: Thomas Huth Signed-off-by: Philippe Mathieu-Daudé --- Thomas, do you think this is the correct place for this function? $ git grep hw_error hw/ | wc -l 145 work to do... Patchew will throw many error