Re: [Qemu-devel] [RFC 6/7] Add offset register to fw_cfg DMA interface

2015-07-22 Thread Marc Marí
On Tue, 21 Jul 2015 22:36:39 +0200 Laszlo Ersek wrote: > On 07/21/15 22:16, Kevin O'Connor wrote: > > On Tue, Jul 21, 2015 at 10:06:51PM +0200, Laszlo Ersek wrote: > >> On 07/21/15 18:26, Stefan Hajnoczi wrote: > >>> On Tue, Jul 21, 2015 at 5:03 PM, Marc Marí > >>> wrote: > Signed-off-by: M

Re: [Qemu-devel] [RFC 6/7] Add offset register to fw_cfg DMA interface

2015-07-21 Thread Kevin O'Connor
On Tue, Jul 21, 2015 at 10:36:39PM +0200, Laszlo Ersek wrote: > On 07/21/15 22:16, Kevin O'Connor wrote: > > Without this ability we'd need to read the entire > > entry into a big linear area of memory and then memmove that around. > > If there is a way to accomplish this without an "offset" field

Re: [Qemu-devel] [RFC 6/7] Add offset register to fw_cfg DMA interface

2015-07-21 Thread Laszlo Ersek
On 07/21/15 22:16, Kevin O'Connor wrote: > On Tue, Jul 21, 2015 at 10:06:51PM +0200, Laszlo Ersek wrote: >> On 07/21/15 18:26, Stefan Hajnoczi wrote: >>> On Tue, Jul 21, 2015 at 5:03 PM, Marc Marí wrote: Signed-off-by: Marc Marí --- hw/nvram/fw_cfg.c | 19 ---

Re: [Qemu-devel] [RFC 6/7] Add offset register to fw_cfg DMA interface

2015-07-21 Thread Kevin O'Connor
On Tue, Jul 21, 2015 at 10:06:51PM +0200, Laszlo Ersek wrote: > On 07/21/15 18:26, Stefan Hajnoczi wrote: > > On Tue, Jul 21, 2015 at 5:03 PM, Marc Marí wrote: > >> Signed-off-by: Marc Marí > >> --- > >> hw/nvram/fw_cfg.c | 19 --- > >> 1 file changed, 16 insertions(+), 3 deletio

Re: [Qemu-devel] [RFC 6/7] Add offset register to fw_cfg DMA interface

2015-07-21 Thread Laszlo Ersek
On 07/21/15 18:26, Stefan Hajnoczi wrote: > On Tue, Jul 21, 2015 at 5:03 PM, Marc Marí wrote: >> Signed-off-by: Marc Marí >> --- >> hw/nvram/fw_cfg.c | 19 --- >> 1 file changed, 16 insertions(+), 3 deletions(-) > > No commit description, no docs/specs/fw_cfg.txt documentation.

[Qemu-devel] [RFC 6/7] Add offset register to fw_cfg DMA interface

2015-07-21 Thread Marc Marí
Signed-off-by: Marc Marí --- hw/nvram/fw_cfg.c | 19 --- 1 file changed, 16 insertions(+), 3 deletions(-) diff --git a/hw/nvram/fw_cfg.c b/hw/nvram/fw_cfg.c index 83205e0..9a39d45 100644 --- a/hw/nvram/fw_cfg.c +++ b/hw/nvram/fw_cfg.c @@ -47,8 +47,9 @@ #define FW_CFG_DMA_ADDR_LO

Re: [Qemu-devel] [RFC 6/7] Add offset register to fw_cfg DMA interface

2015-07-21 Thread Stefan Hajnoczi
On Tue, Jul 21, 2015 at 5:03 PM, Marc Marí wrote: > @@ -338,6 +340,10 @@ static void fw_cfg_dma_transfer(FWCfgState *s) > return; > } > > +for (i = 0; i < s->dma_off; ++i) { > +fw_cfg_read(s); > +} > + > for (i = 0; i < len; i++) { >

Re: [Qemu-devel] [RFC 6/7] Add offset register to fw_cfg DMA interface

2015-07-21 Thread Stefan Hajnoczi
On Tue, Jul 21, 2015 at 5:03 PM, Marc Marí wrote: > Signed-off-by: Marc Marí > --- > hw/nvram/fw_cfg.c | 19 --- > 1 file changed, 16 insertions(+), 3 deletions(-) No commit description, no docs/specs/fw_cfg.txt documentation. I understand how the offset is supposed to work, bu