Re: [Qemu-devel] [RFC 2/7] virtio: stop virtqueue processing if device is broken

2016-03-29 Thread Stefan Hajnoczi
On Tue, Mar 29, 2016 at 09:52:11AM +0200, Cornelia Huck wrote: > On Thu, 24 Mar 2016 17:56:49 + > Stefan Hajnoczi wrote: > > +void GCC_FMT_ATTR(2, 3) virtio_error(VirtIODevice *vdev, const char *fmt, > > ...) > > +{ > > +va_list ap; > > + > > +va_start(ap, fmt); > > +error_vreport

Re: [Qemu-devel] [RFC 2/7] virtio: stop virtqueue processing if device is broken

2016-03-29 Thread Stefan Hajnoczi
On Fri, Mar 25, 2016 at 02:48:37PM +0800, Fam Zheng wrote: > On Thu, 03/24 17:56, Stefan Hajnoczi wrote: > > QEMU prints an error message and exits when the device enters an invalid > > state. Terminating the process is heavy-handed. The guest may still be > > able to function even if there is a

Re: [Qemu-devel] [RFC 2/7] virtio: stop virtqueue processing if device is broken

2016-03-29 Thread Cornelia Huck
On Thu, 24 Mar 2016 17:56:49 + Stefan Hajnoczi wrote: > QEMU prints an error message and exits when the device enters an invalid > state. Terminating the process is heavy-handed. The guest may still be > able to function even if there is a bug in a virtio guest driver. > > Moreover, exitin

Re: [Qemu-devel] [RFC 2/7] virtio: stop virtqueue processing if device is broken

2016-03-24 Thread Fam Zheng
On Thu, 03/24 17:56, Stefan Hajnoczi wrote: > QEMU prints an error message and exits when the device enters an invalid > state. Terminating the process is heavy-handed. The guest may still be > able to function even if there is a bug in a virtio guest driver. > > Moreover, exiting is a bug in ne

[Qemu-devel] [RFC 2/7] virtio: stop virtqueue processing if device is broken

2016-03-24 Thread Stefan Hajnoczi
QEMU prints an error message and exits when the device enters an invalid state. Terminating the process is heavy-handed. The guest may still be able to function even if there is a bug in a virtio guest driver. Moreover, exiting is a bug in nested virtualization where a nested guest could DoS oth