Re: [Qemu-devel] [RFC 17/38] aie: add target helpers

2015-09-21 Thread Alex Bennée
Paolo Bonzini writes: > On 24/08/2015 02:23, Emilio G. Cota wrote: >> +void HELPER(aie_st_pre)(CPUArchState *env, target_ulong vaddr) >> +{ >> +if (unlikely(env->aie_lock_enabled)) { >> +if (env->aie_locked) { >> +return; >> +} > > Now that I've reviewed your code

Re: [Qemu-devel] [RFC 17/38] aie: add target helpers

2015-09-20 Thread Paolo Bonzini
On 24/08/2015 02:23, Emilio G. Cota wrote: > +void HELPER(aie_st_pre)(CPUArchState *env, target_ulong vaddr) > +{ > +if (unlikely(env->aie_lock_enabled)) { > +if (env->aie_locked) { > +return; > +} Now that I've reviewed your code more carefully, the approach you'

Re: [Qemu-devel] [RFC 17/38] aie: add target helpers

2015-09-17 Thread Alex Bennée
Emilio G. Cota writes: > Signed-off-by: Emilio G. Cota > --- > aie-helper.c | 112 > ++ > include/exec/cpu-defs.h | 5 +++ > include/qemu/aie-helper.h | 6 +++ > 3 files changed, 123 insertions(+) > create mode 100644 aie-helper.

[Qemu-devel] [RFC 17/38] aie: add target helpers

2015-08-24 Thread Emilio G. Cota
Signed-off-by: Emilio G. Cota --- aie-helper.c | 112 ++ include/exec/cpu-defs.h | 5 +++ include/qemu/aie-helper.h | 6 +++ 3 files changed, 123 insertions(+) create mode 100644 aie-helper.c create mode 100644 include/qemu/aie-help