Re: [Qemu-devel] [RFC 16/19] target-ppc: Refactor debug output macros

2013-01-27 Thread Alexander Graf
Am 27.01.2013 um 15:54 schrieb Andreas Färber : > Am 27.01.2013 15:46, schrieb Alexander Graf: >> >> On 27.01.2013, at 15:35, Andreas Färber wrote: >> >>> Am 27.01.2013 15:14, schrieb Anthony Liguori: Andreas Färber writes: > diff --git a/target-ppc/excp_helper.c b/target-ppc/excp_he

Re: [Qemu-devel] [RFC 16/19] target-ppc: Refactor debug output macros

2013-01-27 Thread Andreas Färber
Am 27.01.2013 15:46, schrieb Alexander Graf: > > On 27.01.2013, at 15:35, Andreas Färber wrote: > >> Am 27.01.2013 15:14, schrieb Anthony Liguori: >>> Andreas Färber writes: diff --git a/target-ppc/excp_helper.c b/target-ppc/excp_helper.c index 0a1ac86..54722c4 100644 --- a/target

Re: [Qemu-devel] [RFC 16/19] target-ppc: Refactor debug output macros

2013-01-27 Thread Alexander Graf
On 27.01.2013, at 15:35, Andreas Färber wrote: > Am 27.01.2013 15:14, schrieb Anthony Liguori: >> Andreas Färber writes: >>> diff --git a/target-ppc/excp_helper.c b/target-ppc/excp_helper.c >>> index 0a1ac86..54722c4 100644 >>> --- a/target-ppc/excp_helper.c >>> +++ b/target-ppc/excp_helper.c >>

Re: [Qemu-devel] [RFC 16/19] target-ppc: Refactor debug output macros

2013-01-27 Thread Andreas Färber
Am 27.01.2013 15:14, schrieb Anthony Liguori: > Andreas Färber writes: >> diff --git a/target-ppc/excp_helper.c b/target-ppc/excp_helper.c >> index 0a1ac86..54722c4 100644 >> --- a/target-ppc/excp_helper.c >> +++ b/target-ppc/excp_helper.c >> @@ -21,14 +21,14 @@ >> >> #include "helper_regs.h" >

[Qemu-devel] [RFC 16/19] target-ppc: Refactor debug output macros

2013-01-27 Thread Andreas Färber
Make debug output compile-testable even if disabled. Inline DEBUG_OP check in excp_helper.c. Inline LOG_MMU_STATE() in mmu_helper.c. Inline PPC_DEBUG_SPR check in translate_init.c. Signed-off-by: Andreas Färber --- target-ppc/excp_helper.c| 22 +++ target-ppc/kvm.c

Re: [Qemu-devel] [RFC 16/19] target-ppc: Refactor debug output macros

2013-01-27 Thread Anthony Liguori
Andreas Färber writes: > Make debug output compile-testable even if disabled. > > Inline DEBUG_OP check in excp_helper.c. > Inline LOG_MMU_STATE() in mmu_helper.c. > Inline PPC_DEBUG_SPR check in translate_init.c. > > Signed-off-by: Andreas Färber > --- > target-ppc/excp_helper.c| 22