Re: [Qemu-devel] [RFC 1.0] pc_piix: set qxl revision to 2 for pc-0.14

2011-11-15 Thread Anthony Liguori
On 11/13/2011 07:27 AM, Alon Levy wrote: The default is still 3, and I didn't change older machine types. Signed-off-by: Alon Levy Applied. Thanks. Regards, Anthony Liguori --- Is there a better way then copy pasting this to the older pc types to get the revision == 2 for them as well?

Re: [Qemu-devel] [RFC 1.0] pc_piix: set qxl revision to 2 for pc-0.14

2011-11-15 Thread Gerd Hoffmann
Hi, > I mean, change stable-0.15 so that if it is invoked with -M 0.14, you > get a rev 2 qxl device. 0.15 has qxl rev 2 too, 1.0 got rev 3. No need to do anything for -stable. Also 0.15 didn't got its own machine type, so the pc-0.14 compat property (master branch) covers both 0.14 and 0.15.

Re: [Qemu-devel] [RFC 1.0] pc_piix: set qxl revision to 2 for pc-0.14

2011-11-14 Thread Avi Kivity
On 11/14/2011 07:48 PM, Anthony Liguori wrote: > On 11/14/2011 11:45 AM, Avi Kivity wrote: >> On 11/14/2011 06:07 PM, Anthony Liguori wrote: Antony, can you apply this directly or do you wanna have a single-patch-pull-request instead? >>> >>> >>> Yes, I'll apply directly. >> >> Does stabl

Re: [Qemu-devel] [RFC 1.0] pc_piix: set qxl revision to 2 for pc-0.14

2011-11-14 Thread Anthony Liguori
On 11/14/2011 11:45 AM, Avi Kivity wrote: On 11/14/2011 06:07 PM, Anthony Liguori wrote: Antony, can you apply this directly or do you wanna have a single-patch-pull-request instead? Yes, I'll apply directly. Does stable-0.15 need it too? You mean to set the revision to 2 for 0.14, right?

Re: [Qemu-devel] [RFC 1.0] pc_piix: set qxl revision to 2 for pc-0.14

2011-11-14 Thread Avi Kivity
On 11/14/2011 06:07 PM, Anthony Liguori wrote: >> Antony, can you apply this directly or do you wanna have a >> single-patch-pull-request instead? > > > Yes, I'll apply directly. Does stable-0.15 need it too? -- error compiling committee.c: too many arguments to function

Re: [Qemu-devel] [RFC 1.0] pc_piix: set qxl revision to 2 for pc-0.14

2011-11-14 Thread Anthony Liguori
On 11/14/2011 09:55 AM, Gerd Hoffmann wrote: On 11/14/11 12:44, Alon Levy wrote: On Mon, Nov 14, 2011 at 11:40:57AM +0100, Gerd Hoffmann wrote: On 11/13/11 14:27, Alon Levy wrote: The default is still 3, and I didn't change older machine types. Looks good to me. ok, so do you want another

Re: [Qemu-devel] [RFC 1.0] pc_piix: set qxl revision to 2 for pc-0.14

2011-11-14 Thread Gerd Hoffmann
On 11/14/11 12:44, Alon Levy wrote: > On Mon, Nov 14, 2011 at 11:40:57AM +0100, Gerd Hoffmann wrote: >> On 11/13/11 14:27, Alon Levy wrote: >>> The default is still 3, and I didn't change older machine types. >> >> Looks good to me. >> > > ok, so do you want another email with subject PATCH or can

Re: [Qemu-devel] [RFC 1.0] pc_piix: set qxl revision to 2 for pc-0.14

2011-11-14 Thread Alon Levy
On Mon, Nov 14, 2011 at 11:40:57AM +0100, Gerd Hoffmann wrote: > On 11/13/11 14:27, Alon Levy wrote: > > The default is still 3, and I didn't change older machine types. > > Looks good to me. > ok, so do you want another email with subject PATCH or can I consider this in the queue? > > Signed-o

Re: [Qemu-devel] [RFC 1.0] pc_piix: set qxl revision to 2 for pc-0.14

2011-11-14 Thread Gerd Hoffmann
On 11/13/11 14:27, Alon Levy wrote: > The default is still 3, and I didn't change older machine types. Looks good to me. > Signed-off-by: Alon Levy > --- > Is there a better way then copy pasting this to the older pc types to get > the revision == 2 for them as well? Unfortunaly not, although w

[Qemu-devel] [RFC 1.0] pc_piix: set qxl revision to 2 for pc-0.14

2011-11-13 Thread Alon Levy
The default is still 3, and I didn't change older machine types. Signed-off-by: Alon Levy --- Is there a better way then copy pasting this to the older pc types to get the revision == 2 for them as well? hw/pc_piix.c | 12 1 files changed, 12 insertions(+), 0 deletions(-) diff -