Re: [Qemu-devel] [RFC 1/4] Fix issue affecting get_int32_le() in vmstate.c

2014-02-25 Thread Peter Maydell
On 25 February 2014 18:52, Juan Quintela wrote: > BTW, did you find this bug by testing or by code inspection? Trying a KVM<->TCG migration of an ARM guest will likely hit the bug (because the number of coprocessor registers on either end differs). thanks -- PMM

Re: [Qemu-devel] [RFC 1/4] Fix issue affecting get_int32_le() in vmstate.c

2014-02-25 Thread Juan Quintela
Alvise Rigo wrote: > The method is not behaving in the way it's supposed to. It should return > the new value only if it's less than the actual one. > > Signed-off-by: Alvise Rigo See David patch of this function. There were a bug, we were doing the wrong comparison. But we expect not to chang

Re: [Qemu-devel] [RFC 1/4] Fix issue affecting get_int32_le() in vmstate.c

2014-02-25 Thread Peter Maydell
On 25 February 2014 16:52, Alvise Rigo wrote: > The method is not behaving in the way it's supposed to. It should return > the new value only if it's less than the actual one. > > Signed-off-by: Alvise Rigo This clashes with David Gilbert's patch to this function: http://patchwork.ozlabs.org/pa

Re: [Qemu-devel] [RFC 1/4] Fix issue affecting get_int32_le() in vmstate.c

2014-02-25 Thread Eduardo Habkost
On Tue, Feb 25, 2014 at 05:52:47PM +0100, Alvise Rigo wrote: > The method is not behaving in the way it's supposed to. It should return > the new value only if it's less than the actual one. > > Signed-off-by: Alvise Rigo > --- > vmstate.c | 8 > 1 file changed, 4 insertions(+), 4 delet

[Qemu-devel] [RFC 1/4] Fix issue affecting get_int32_le() in vmstate.c

2014-02-25 Thread Alvise Rigo
The method is not behaving in the way it's supposed to. It should return the new value only if it's less than the actual one. Signed-off-by: Alvise Rigo --- vmstate.c | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/vmstate.c b/vmstate.c index 284b080..038b274 100644 -