Re: [Qemu-devel] [RFC 07/29] migration: better error handling with QEMUFile

2017-07-31 Thread Peter Xu
On Mon, Jul 31, 2017 at 07:39:24PM +0100, Dr. David Alan Gilbert wrote: > * Peter Xu (pet...@redhat.com) wrote: [...] > > @@ -2425,6 +2425,16 @@ static int ram_load_postcopy(QEMUFile *f) > > uint8_t ch; > > > > addr = qemu_get_be64(f); > > + > > +/* > > + * If

Re: [Qemu-devel] [RFC 07/29] migration: better error handling with QEMUFile

2017-07-31 Thread Dr. David Alan Gilbert
* Peter Xu (pet...@redhat.com) wrote: > If the postcopy down due to some reason, we can always see this on dst: > > qemu-system-x86_64: RP: Received invalid message 0x length 0x > > However in most cases that's not the real issue. The problem is that > qemu_get_be16() has no way to show

[Qemu-devel] [RFC 07/29] migration: better error handling with QEMUFile

2017-07-28 Thread Peter Xu
If the postcopy down due to some reason, we can always see this on dst: qemu-system-x86_64: RP: Received invalid message 0x length 0x However in most cases that's not the real issue. The problem is that qemu_get_be16() has no way to show whether the returned data is valid or not, and we