Re: [Qemu-devel] [RFC 05/10] serial: Allow to reconfigure ISA I/O base

2011-06-06 Thread Andreas Färber
Am 06.06.2011 um 22:08 schrieb Richard Henderson: On 06/06/2011 11:20 AM, Andreas Färber wrote: +if (iobase != isa->iobase) { +isa->iobase = iobase; +serial_isa_init_iobase(isa); Forgot to unregister here? Yeah, looks like it. Thanks. Probably some stylistic issues, too

Re: [Qemu-devel] [RFC 05/10] serial: Allow to reconfigure ISA I/O base

2011-06-06 Thread Richard Henderson
On 06/06/2011 11:20 AM, Andreas Färber wrote: > +if (iobase != isa->iobase) { > +isa->iobase = iobase; > +serial_isa_init_iobase(isa); Forgot to unregister here? r~

[Qemu-devel] [RFC 05/10] serial: Allow to reconfigure ISA I/O base

2011-06-06 Thread Andreas Färber
Signed-off-by: Andreas Färber --- hw/isa.h|3 +++ hw/serial.c | 23 --- 2 files changed, 23 insertions(+), 3 deletions(-) diff --git a/hw/isa.h b/hw/isa.h index 54698b5..8bd082a 100644 --- a/hw/isa.h +++ b/hw/isa.h @@ -45,6 +45,9 @@ void isa_mmio_init(target_phys_ad