Re: [Qemu-devel] [RFC 04/38] translate-all: remove volatile from have_tb_lock

2015-09-07 Thread Paolo Bonzini
On 07/09/2015 17:50, Alex Bennée wrote: >> > /* translation block context */ >> > -__thread volatile int have_tb_lock; >> > +__thread int have_tb_lock; > Reviewed-by: Alex Bennée > > but really should be folded into the original patches. > Yup, v2 will come soon. Paolo

Re: [Qemu-devel] [RFC 04/38] translate-all: remove volatile from have_tb_lock

2015-09-07 Thread Alex Bennée
Emilio G. Cota writes: > This is a thread-local variable and therefore all changes > to it will be seen in order by the owning thread. There is > no need for it to be volatile. > > Signed-off-by: Emilio G. Cota > --- > translate-all.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > >

[Qemu-devel] [RFC 04/38] translate-all: remove volatile from have_tb_lock

2015-08-23 Thread Emilio G. Cota
This is a thread-local variable and therefore all changes to it will be seen in order by the owning thread. There is no need for it to be volatile. Signed-off-by: Emilio G. Cota --- translate-all.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/translate-all.c b/translate-al