Re: [Qemu-devel] [RFC 0/3] target/m68k: fix TCGv array overflow

2018-03-16 Thread Laurent Vivier
Le 15/03/2018 à 20:34, Richard Henderson a écrit : > On 03/16/2018 03:19 AM, Laurent Vivier wrote: >> I try to fix this by introducing a new TCG function >> to try to free a TCGv if it is a temporary one and >> do nothing otherwise (patches 1 and 2) > > I would prefer not to approach this in this

Re: [Qemu-devel] [RFC 0/3] target/m68k: fix TCGv array overflow

2018-03-15 Thread Richard Henderson
On 03/16/2018 03:19 AM, Laurent Vivier wrote: > I try to fix this by introducing a new TCG function > to try to free a TCGv if it is a temporary one and > do nothing otherwise (patches 1 and 2) I would prefer not to approach this in this way. Better is to have translator helpers that allocate tem

[Qemu-devel] [RFC 0/3] target/m68k: fix TCGv array overflow

2018-03-15 Thread Laurent Vivier
Since commit 15fa08f845 ("tcg: Dynamically allocate TCGOps") we have no limit to fill the TCGOps cache and we can fill the entire TCG variables array and overflow it. It seems to happen only with m68k, because m68k translator doesn't free some TCGv at end of instruction translation because the var