Re: [Qemu-devel] [RFC-PATCH] Introducing virtio-example device.

2019-04-14 Thread Yoni Bettan
On 4/10/19 10:25 PM, Stefan Hajnoczi wrote: On Wed, Apr 10, 2019 at 4:45 PM Yoni Bettan wrote: On 4/9/19 4:17 PM, Stefan Hajnoczi wrote: On Mon, Apr 01, 2019 at 02:18:43PM +0300, Yoni Bettan wrote: There are multiple problems with the code, but the larger issue is that this example device is

Re: [Qemu-devel] [RFC-PATCH] Introducing virtio-example device.

2019-04-10 Thread Michael S. Tsirkin
On Wed, Apr 10, 2019 at 08:15:32PM +0100, Stefan Hajnoczi wrote: > On Wed, Apr 10, 2019 at 4:45 PM Yoni Bettan wrote: > > On 4/9/19 4:17 PM, Stefan Hajnoczi wrote: > > > On Mon, Apr 01, 2019 at 02:18:43PM +0300, Yoni Bettan wrote: > > The final purpose is to have: > > > > 1. device specification >

Re: [Qemu-devel] [RFC-PATCH] Introducing virtio-example device.

2019-04-10 Thread Stefan Hajnoczi
On Wed, Apr 10, 2019 at 4:45 PM Yoni Bettan wrote: > On 4/9/19 4:17 PM, Stefan Hajnoczi wrote: > > On Mon, Apr 01, 2019 at 02:18:43PM +0300, Yoni Bettan wrote: > The final purpose is to have: > > 1. device specification > > 2. device implementation > > 3. device driver > > 4. blog > > maybe I shou

Re: [Qemu-devel] [RFC-PATCH] Introducing virtio-example device.

2019-04-10 Thread Stefan Hajnoczi
On Wed, Apr 10, 2019 at 4:45 PM Yoni Bettan wrote: > On 4/9/19 4:17 PM, Stefan Hajnoczi wrote: > > On Mon, Apr 01, 2019 at 02:18:43PM +0300, Yoni Bettan wrote: > > There are multiple problems with the code, but the larger issue is that > > this example device is just helping people shoot themselve

Re: [Qemu-devel] [RFC-PATCH] Introducing virtio-example device.

2019-04-10 Thread Yoni Bettan
On 4/9/19 4:17 PM, Stefan Hajnoczi wrote: On Mon, Apr 01, 2019 at 02:18:43PM +0300, Yoni Bettan wrote: The main goal is to add an example device to Qemu to be used as template or guideline for contributors when they wish to create a new virtio device. Another reason for this device is to docu

Re: [Qemu-devel] [RFC-PATCH] Introducing virtio-example device.

2019-04-09 Thread Stefan Hajnoczi
On Mon, Apr 01, 2019 at 02:18:43PM +0300, Yoni Bettan wrote: > The main goal is to add an example device to Qemu to be used as template or > guideline for contributors when they wish to create a new virtio device. > > Another reason for this device is to document "the right way" to write > a new v

Re: [Qemu-devel] [RFC-PATCH] Introducing virtio-example device.

2019-04-05 Thread Eduardo Habkost
Hi, Thanks for the patch, comments below: On Mon, Apr 01, 2019 at 02:18:43PM +0300, Yoni Bettan wrote: > The main goal is to add an example device to Qemu to be used as template or > guideline for contributors when they wish to create a new virtio device. > > Another reason for this device is to

[Qemu-devel] [RFC-PATCH] Introducing virtio-example device.

2019-04-01 Thread Yoni Bettan
The main goal is to add an example device to Qemu to be used as template or guideline for contributors when they wish to create a new virtio device. Another reason for this device is to document "the right way" to write a new virtio device in Qemu. This device is a simple device and its functiona