Re: [Qemu-devel] [RFC] vhost-user: don't ignore CTRL_VLAN feature

2019-07-18 Thread Tiwei Bie
On Wed, Jul 17, 2019 at 07:00:25AM -0400, Michael S. Tsirkin wrote: > On Wed, Jun 12, 2019 at 10:11:57AM +0800, Tiwei Bie wrote: > > On Tue, Jun 11, 2019 at 10:10:14AM -0400, Michael S. Tsirkin wrote: > > > On Tue, Jun 11, 2019 at 02:51:37PM +0800, Tiwei Bie wrote: > > > > The VIRTIO_NET_F_CTRL_VLA

Re: [Qemu-devel] [RFC] vhost-user: don't ignore CTRL_VLAN feature

2019-07-17 Thread Michael S. Tsirkin
On Wed, Jul 17, 2019 at 08:30:29PM +0800, Jason Wang wrote: > > On 2019/7/17 下午7:00, Michael S. Tsirkin wrote: > > On Wed, Jun 12, 2019 at 10:11:57AM +0800, Tiwei Bie wrote: > > > On Tue, Jun 11, 2019 at 10:10:14AM -0400, Michael S. Tsirkin wrote: > > > > On Tue, Jun 11, 2019 at 02:51:37PM +0800,

Re: [Qemu-devel] [RFC] vhost-user: don't ignore CTRL_VLAN feature

2019-07-17 Thread Jason Wang
On 2019/7/17 下午7:00, Michael S. Tsirkin wrote: On Wed, Jun 12, 2019 at 10:11:57AM +0800, Tiwei Bie wrote: On Tue, Jun 11, 2019 at 10:10:14AM -0400, Michael S. Tsirkin wrote: On Tue, Jun 11, 2019 at 02:51:37PM +0800, Tiwei Bie wrote: The VIRTIO_NET_F_CTRL_VLAN feature requires the support of

Re: [Qemu-devel] [RFC] vhost-user: don't ignore CTRL_VLAN feature

2019-07-17 Thread Michael S. Tsirkin
On Wed, Jun 12, 2019 at 10:11:57AM +0800, Tiwei Bie wrote: > On Tue, Jun 11, 2019 at 10:10:14AM -0400, Michael S. Tsirkin wrote: > > On Tue, Jun 11, 2019 at 02:51:37PM +0800, Tiwei Bie wrote: > > > The VIRTIO_NET_F_CTRL_VLAN feature requires the support of > > > vhost-user backend. But it will be a

Re: [Qemu-devel] [RFC] vhost-user: don't ignore CTRL_VLAN feature

2019-06-11 Thread Tiwei Bie
On Tue, Jun 11, 2019 at 03:22:47PM +0800, Jason Wang wrote: > > On 2019/6/11 下午2:51, Tiwei Bie wrote: > > The VIRTIO_NET_F_CTRL_VLAN feature requires the support of > > vhost-user backend. But it will be advertised to guest driver > > as long as it's enabled by users in QEMU, while it's not > > su

Re: [Qemu-devel] [RFC] vhost-user: don't ignore CTRL_VLAN feature

2019-06-11 Thread Tiwei Bie
On Tue, Jun 11, 2019 at 10:10:14AM -0400, Michael S. Tsirkin wrote: > On Tue, Jun 11, 2019 at 02:51:37PM +0800, Tiwei Bie wrote: > > The VIRTIO_NET_F_CTRL_VLAN feature requires the support of > > vhost-user backend. But it will be advertised to guest driver > > as long as it's enabled by users in Q

Re: [Qemu-devel] [RFC] vhost-user: don't ignore CTRL_VLAN feature

2019-06-11 Thread Michael S. Tsirkin
On Tue, Jun 11, 2019 at 02:51:37PM +0800, Tiwei Bie wrote: > The VIRTIO_NET_F_CTRL_VLAN feature requires the support of > vhost-user backend. But it will be advertised to guest driver > as long as it's enabled by users in QEMU, while it's not > supported by vhost-user backend. This patch fixes this

Re: [Qemu-devel] [RFC] vhost-user: don't ignore CTRL_VLAN feature

2019-06-11 Thread Jason Wang
On 2019/6/11 下午2:51, Tiwei Bie wrote: The VIRTIO_NET_F_CTRL_VLAN feature requires the support of vhost-user backend. But it will be advertised to guest driver as long as it's enabled by users in QEMU, while it's not supported by vhost-user backend. This patch fixes this issue. Fixes: 72018d1e1

[Qemu-devel] [RFC] vhost-user: don't ignore CTRL_VLAN feature

2019-06-10 Thread Tiwei Bie
The VIRTIO_NET_F_CTRL_VLAN feature requires the support of vhost-user backend. But it will be advertised to guest driver as long as it's enabled by users in QEMU, while it's not supported by vhost-user backend. This patch fixes this issue. Fixes: 72018d1e1917 ("vhost-user: ignore qemu-only feature