Re: [Qemu-devel] [RFC] tests: Add ivshmem qtest

2014-04-03 Thread Michael S. Tsirkin
On Thu, Apr 03, 2014 at 01:23:08PM +0200, Andreas Färber wrote: > Am 03.04.2014 13:16, schrieb Michael S. Tsirkin: > > On Wed, Apr 02, 2014 at 05:15:59PM +0200, Paolo Bonzini wrote: > >> Il 02/04/2014 17:15, Michael S. Tsirkin ha scritto: > >>> Yes and I think this someone was you actually. > >>> C

Re: [Qemu-devel] [RFC] tests: Add ivshmem qtest

2014-04-03 Thread Stefan Hajnoczi
On Thu, Apr 03, 2014 at 01:45:28PM +0200, Andreas Färber wrote: > Am 03.04.2014 10:46, schrieb Stefan Hajnoczi: > > The name should be unique and we should clean up in both success and > > failure (abort(3)) cases. > > The recipe for unique filenames elsewhere is mkstemp(), which I was > planning

Re: [Qemu-devel] [RFC] tests: Add ivshmem qtest

2014-04-03 Thread Andreas Färber
Am 03.04.2014 10:46, schrieb Stefan Hajnoczi: > On Wed, Apr 02, 2014 at 04:57:48PM +0200, Andreas Färber wrote: >> +int main(int argc, char **argv) >> +{ >> +QTestState *s1, *s2; >> +char *cmd; >> +int ret; >> + >> +g_test_init(&argc, &argv, NULL); >> +qtest_add_func("/ivshmem/n

Re: [Qemu-devel] [RFC] tests: Add ivshmem qtest

2014-04-03 Thread Andreas Färber
Am 03.04.2014 13:16, schrieb Michael S. Tsirkin: > On Wed, Apr 02, 2014 at 05:15:59PM +0200, Paolo Bonzini wrote: >> Il 02/04/2014 17:15, Michael S. Tsirkin ha scritto: >>> Yes and I think this someone was you actually. >>> Can something similar be done for this test? >>> >> >> I think ivshmem depe

Re: [Qemu-devel] [RFC] tests: Add ivshmem qtest

2014-04-03 Thread Michael S. Tsirkin
On Wed, Apr 02, 2014 at 05:15:59PM +0200, Paolo Bonzini wrote: > Il 02/04/2014 17:15, Michael S. Tsirkin ha scritto: > >Yes and I think this someone was you actually. > >Can something similar be done for this test? > > > > I think ivshmem depends on ioeventfd, doesn't it? So short of > implementi

Re: [Qemu-devel] [RFC] tests: Add ivshmem qtest

2014-04-03 Thread Stefan Hajnoczi
On Wed, Apr 02, 2014 at 04:57:48PM +0200, Andreas Färber wrote: > +int main(int argc, char **argv) > +{ > +QTestState *s1, *s2; > +char *cmd; > +int ret; > + > +g_test_init(&argc, &argv, NULL); > +qtest_add_func("/ivshmem/nop", nop); > + > +cmd = g_strdup_printf("-device ivs

Re: [Qemu-devel] [RFC] tests: Add ivshmem qtest

2014-04-02 Thread Paolo Bonzini
Il 02/04/2014 17:15, Michael S. Tsirkin ha scritto: Yes and I think this someone was you actually. Can something similar be done for this test? I think ivshmem depends on ioeventfd, doesn't it? So short of implementing ioeventfd for TCG, no. Paolo

Re: [Qemu-devel] [RFC] tests: Add ivshmem qtest

2014-04-02 Thread Michael S. Tsirkin
On Wed, Apr 02, 2014 at 05:07:09PM +0200, Andreas Färber wrote: > Am 02.04.2014 17:06, schrieb Michael S. Tsirkin: > > On Wed, Apr 02, 2014 at 04:57:48PM +0200, Andreas Färber wrote: > >> Note that it launches two instances to as sharing memory is the purpose > >> of Nahanni/ivshmem. > >> > >> Cc:

Re: [Qemu-devel] [RFC] tests: Add ivshmem qtest

2014-04-02 Thread Michael S. Tsirkin
On Wed, Apr 02, 2014 at 04:57:48PM +0200, Andreas Färber wrote: > Note that it launches two instances to as sharing memory is the purpose > of Nahanni/ivshmem. > > Cc: Cam Macdonell > Signed-off-by: Andreas Färber > --- > This test demonstrates a use case of running two QEMU instances in qtest.

Re: [Qemu-devel] [RFC] tests: Add ivshmem qtest

2014-04-02 Thread Andreas Färber
Am 02.04.2014 17:06, schrieb Michael S. Tsirkin: > On Wed, Apr 02, 2014 at 04:57:48PM +0200, Andreas Färber wrote: >> Note that it launches two instances to as sharing memory is the purpose >> of Nahanni/ivshmem. >> >> Cc: Cam Macdonell >> Signed-off-by: Andreas Färber >> --- >> This test demons

[Qemu-devel] [RFC] tests: Add ivshmem qtest

2014-04-02 Thread Andreas Färber
Note that it launches two instances to as sharing memory is the purpose of Nahanni/ivshmem. Cc: Cam Macdonell Signed-off-by: Andreas Färber --- This test demonstrates a use case of running two QEMU instances in qtest. However, similar to mst's proposed KVM acpi-test, it fails on systems with