Re: [Qemu-devel] [RFC] qxl: don't panic on phys2virt

2012-04-24 Thread Gerd Hoffmann
On 03/30/12 21:27, Alon Levy wrote: > On Fri, Mar 30, 2012 at 10:09:42AM +0200, Gerd Hoffmann wrote: >> On 03/29/12 22:56, Alon Levy wrote: >>> Issues a qxl_guest_bug from qxl_phys2virt. Everywhere else will fail. >> >> Nice start (there are more guest-triggerable asserts to be fixed this way). >>

Re: [Qemu-devel] [RFC] qxl: don't panic on phys2virt

2012-03-30 Thread Alon Levy
On Fri, Mar 30, 2012 at 10:09:42AM +0200, Gerd Hoffmann wrote: > On 03/29/12 22:56, Alon Levy wrote: > > Issues a qxl_guest_bug from qxl_phys2virt. Everywhere else will fail. > > Nice start (there are more guest-triggerable asserts to be fixed this way). > > > qxl_phys2virt requires an additional

Re: [Qemu-devel] [RFC] qxl: don't panic on phys2virt

2012-03-30 Thread Gerd Hoffmann
On 03/29/12 22:56, Alon Levy wrote: > Issues a qxl_guest_bug from qxl_phys2virt. Everywhere else will fail. Nice start (there are more guest-triggerable asserts to be fixed this way). > qxl_phys2virt requires an additional argument because all it's possible > return values are legit (well, I coul

[Qemu-devel] [RFC] qxl: don't panic on phys2virt

2012-03-29 Thread Alon Levy
Issues a qxl_guest_bug from qxl_phys2virt. Everywhere else will fail. qxl_phys2virt requires an additional argument because all it's possible return values are legit (well, I could use the fact it returns a pointer so it should be word aligned but I don't want to go there, this is totally internal)