Re: [Qemu-devel] [RFC] qid path collision issues in 9pfs

2018-01-29 Thread Greg Kurz
On Thu, 25 Jan 2018 17:08:40 +0100 Veaceslav Falico wrote: > On 1/25/2018 3:46 PM, Veaceslav Falico wrote: [...] > > > > I've reproduced it today without fscache: > > > > host: > > mount -o bind /tmp/mounted t1 > > mount -o bind /tmp/mounted t2 > > > > guest: > > / # tail -f t1/file & > > / #

Re: [Qemu-devel] [RFC] qid path collision issues in 9pfs

2018-01-25 Thread Veaceslav Falico
On 1/25/2018 3:46 PM, Veaceslav Falico wrote: > Hi, > > sorry for the late reply, we're acutally working on it internally... > > On 1/19/2018 7:05 PM, Greg Kurz wrote: >> On Fri, 19 Jan 2018 17:37:58 +0100 >> Veaceslav Falico wrote: >> >>> On 1/19/2018 4:52 PM, Eduard Shishkin wrote: >

Re: [Qemu-devel] [RFC] qid path collision issues in 9pfs

2018-01-25 Thread Veaceslav Falico
Hi, sorry for the late reply, we're acutally working on it internally... On 1/19/2018 7:05 PM, Greg Kurz wrote: > On Fri, 19 Jan 2018 17:37:58 +0100 > Veaceslav Falico wrote: > >> On 1/19/2018 4:52 PM, Eduard Shishkin wrote: >>> >>> >>> On 1/19/2018 11:27 AM, Greg Kurz wrote: On Mon, 15

Re: [Qemu-devel] [RFC] qid path collision issues in 9pfs

2018-01-24 Thread Eduard Shishkin
On 1/24/2018 5:40 PM, Antonios Motakis wrote: On 01/24/2018 02:30 PM, Greg Kurz wrote: Thanks Emilio for providing these valuable suggestions ! :) On Sat, 20 Jan 2018 17:03:49 -0500 "Emilio G. Cota" wrote: On Fri, Jan 19, 2018 at 19:05:06 -0500, Emilio G. Cota wrote: On Fri, 12 Jan 2018

Re: [Qemu-devel] [RFC] qid path collision issues in 9pfs

2018-01-24 Thread Antonios Motakis
On 01/24/2018 02:30 PM, Greg Kurz wrote: Thanks Emilio for providing these valuable suggestions ! :) On Sat, 20 Jan 2018 17:03:49 -0500 "Emilio G. Cota" wrote: On Fri, Jan 19, 2018 at 19:05:06 -0500, Emilio G. Cota wrote: On Fri, 12 Jan 2018 19:32:10 +0800 Antonios Motakis wrote: Since i

Re: [Qemu-devel] [RFC] qid path collision issues in 9pfs

2018-01-24 Thread Greg Kurz
On Mon, 22 Jan 2018 13:40:00 +0100 Eduard Shishkin wrote: > On 1/19/2018 5:37 PM, Veaceslav Falico wrote: > > On 1/19/2018 4:52 PM, Eduard Shishkin wrote: > >> > >> > >> On 1/19/2018 11:27 AM, Greg Kurz wrote: > >>> On Mon, 15 Jan 2018 11:49:31 +0800 > >>> Antonios Motakis wrote: > >>> > >

Re: [Qemu-devel] [RFC] qid path collision issues in 9pfs

2018-01-24 Thread Greg Kurz
Thanks Emilio for providing these valuable suggestions ! :) On Sat, 20 Jan 2018 17:03:49 -0500 "Emilio G. Cota" wrote: > On Fri, Jan 19, 2018 at 19:05:06 -0500, Emilio G. Cota wrote: > > > > > On Fri, 12 Jan 2018 19:32:10 +0800 > > > > > Antonios Motakis wrote: > > > > Since inodes are not co

Re: [Qemu-devel] [RFC] qid path collision issues in 9pfs

2018-01-22 Thread Eduard Shishkin
On 1/19/2018 5:37 PM, Veaceslav Falico wrote: On 1/19/2018 4:52 PM, Eduard Shishkin wrote: On 1/19/2018 11:27 AM, Greg Kurz wrote: On Mon, 15 Jan 2018 11:49:31 +0800 Antonios Motakis wrote: On 13-Jan-18 00:14, Greg Kurz wrote: On Fri, 12 Jan 2018 19:32:10 +0800 Antonios Motakis wrote:

Re: [Qemu-devel] [RFC] qid path collision issues in 9pfs

2018-01-20 Thread Emilio G. Cota
On Fri, Jan 19, 2018 at 19:05:06 -0500, Emilio G. Cota wrote: > > > > On Fri, 12 Jan 2018 19:32:10 +0800 > > > > Antonios Motakis wrote: > > > Since inodes are not completely random, and we usually have a handful of > > > device IDs, > > > we get a much smaller number of entries to track in the h

Re: [Qemu-devel] [RFC] qid path collision issues in 9pfs

2018-01-19 Thread Emilio G. Cota
On Fri, Jan 19, 2018 at 11:27:33 +0100, Greg Kurz wrote: > On Mon, 15 Jan 2018 11:49:31 +0800 > Antonios Motakis wrote: > > On 13-Jan-18 00:14, Greg Kurz wrote: > > > On Fri, 12 Jan 2018 19:32:10 +0800 > > > Antonios Motakis wrote: (snip) > > >> To avoid this situation, the device id of a file ne

Re: [Qemu-devel] [RFC] qid path collision issues in 9pfs

2018-01-19 Thread Eduard Shishkin
On 1/19/2018 7:05 PM, Greg Kurz wrote: On Fri, 19 Jan 2018 17:37:58 +0100 Veaceslav Falico wrote: On 1/19/2018 4:52 PM, Eduard Shishkin wrote: On 1/19/2018 11:27 AM, Greg Kurz wrote: On Mon, 15 Jan 2018 11:49:31 +0800 Antonios Motakis wrote: On 13-Jan-18 00:14, Greg Kurz wrote: On Fr

Re: [Qemu-devel] [RFC] qid path collision issues in 9pfs

2018-01-19 Thread Greg Kurz
On Fri, 19 Jan 2018 17:37:58 +0100 Veaceslav Falico wrote: > On 1/19/2018 4:52 PM, Eduard Shishkin wrote: > > > > > > On 1/19/2018 11:27 AM, Greg Kurz wrote: > >> On Mon, 15 Jan 2018 11:49:31 +0800 > >> Antonios Motakis wrote: > >> > >>> On 13-Jan-18 00:14, Greg Kurz wrote: > On Fri

Re: [Qemu-devel] [RFC] qid path collision issues in 9pfs

2018-01-19 Thread Veaceslav Falico
On 1/19/2018 4:52 PM, Eduard Shishkin wrote: > > > On 1/19/2018 11:27 AM, Greg Kurz wrote: >> On Mon, 15 Jan 2018 11:49:31 +0800 >> Antonios Motakis wrote: >> >>> On 13-Jan-18 00:14, Greg Kurz wrote: On Fri, 12 Jan 2018 19:32:10 +0800 Antonios Motakis wrote: > Hello all,

Re: [Qemu-devel] [RFC] qid path collision issues in 9pfs

2018-01-19 Thread Greg Kurz
On Fri, 19 Jan 2018 16:52:44 +0100 Eduard Shishkin wrote: > On 1/19/2018 11:27 AM, Greg Kurz wrote: > > On Mon, 15 Jan 2018 11:49:31 +0800 > > Antonios Motakis wrote: > > > >> On 13-Jan-18 00:14, Greg Kurz wrote: > >>> On Fri, 12 Jan 2018 19:32:10 +0800 > >>> Antonios Motakis wrote: > >>>

Re: [Qemu-devel] [RFC] qid path collision issues in 9pfs

2018-01-19 Thread Eduard Shishkin
On 1/19/2018 11:27 AM, Greg Kurz wrote: On Mon, 15 Jan 2018 11:49:31 +0800 Antonios Motakis wrote: On 13-Jan-18 00:14, Greg Kurz wrote: On Fri, 12 Jan 2018 19:32:10 +0800 Antonios Motakis wrote: Hello all, Hi Antonios, I see you have attached a patch to this email... this really isn'

Re: [Qemu-devel] [RFC] qid path collision issues in 9pfs

2018-01-19 Thread Greg Kurz
On Mon, 15 Jan 2018 11:49:31 +0800 Antonios Motakis wrote: > On 13-Jan-18 00:14, Greg Kurz wrote: > > On Fri, 12 Jan 2018 19:32:10 +0800 > > Antonios Motakis wrote: > > > >> Hello all, > >> > > > > Hi Antonios, > > > > I see you have attached a patch to this email... this really isn't the

Re: [Qemu-devel] [RFC] qid path collision issues in 9pfs

2018-01-14 Thread Antonios Motakis
On 13-Jan-18 00:14, Greg Kurz wrote: > On Fri, 12 Jan 2018 19:32:10 +0800 > Antonios Motakis wrote: > >> Hello all, >> > > Hi Antonios, > > I see you have attached a patch to this email... this really isn't the > preferred > way to do things since it prevents to comment the patch (at least w

Re: [Qemu-devel] [RFC] qid path collision issues in 9pfs

2018-01-12 Thread Greg Kurz
u-devel@nongnu.org; Greg Kurz; zhangwei (CR); Veaceslav Falico; Eduard > Shishkin; Wangguoli (Andy); Jiangyiwen; vfal...@gmail.com; Jani Kokkonen > Subject: Re: [Qemu-devel] [RFC] qid path collision issues in 9pfs > > On Fri, Jan 12, 2018 at 07:32:10PM +0800, Antonios Motakis wrote: > > Hel

Re: [Qemu-devel] [RFC] qid path collision issues in 9pfs

2018-01-12 Thread Veaceslav Falico
Berrange [mailto:berra...@redhat.com] Sent: Friday, January 12, 2018 3:27 PM To: Antonios Motakis (Tony) Cc: qemu-devel@nongnu.org; Greg Kurz; zhangwei (CR); Veaceslav Falico; Eduard Shishkin; Wangguoli (Andy); Jiangyiwen; vfal...@gmail.com; Jani Kokkonen Subject: Re: [Qemu-devel] [RFC] qid path collision

Re: [Qemu-devel] [RFC] qid path collision issues in 9pfs

2018-01-12 Thread Greg Kurz
On Fri, 12 Jan 2018 14:27:22 + "Daniel P. Berrange" wrote: > On Fri, Jan 12, 2018 at 07:32:10PM +0800, Antonios Motakis wrote: > > Hello all, > > > > We have found an issue in the 9p implementation of QEMU, with how qid paths > > are generated, which can cause qid path collisions and several

Re: [Qemu-devel] [RFC] qid path collision issues in 9pfs

2018-01-12 Thread Greg Kurz
On Fri, 12 Jan 2018 19:32:10 +0800 Antonios Motakis wrote: > Hello all, > Hi Antonios, I see you have attached a patch to this email... this really isn't the preferred way to do things since it prevents to comment the patch (at least with my mail client). The appropriate way would have been to

Re: [Qemu-devel] [RFC] qid path collision issues in 9pfs

2018-01-12 Thread Daniel P. Berrange
On Fri, Jan 12, 2018 at 07:32:10PM +0800, Antonios Motakis wrote: > Hello all, > > We have found an issue in the 9p implementation of QEMU, with how qid paths > are generated, which can cause qid path collisions and several issues caused > by them. In our use case (running containers under VMs) th

[Qemu-devel] [RFC] qid path collision issues in 9pfs

2018-01-12 Thread Antonios Motakis
Hello all, We have found an issue in the 9p implementation of QEMU, with how qid paths are generated, which can cause qid path collisions and several issues caused by them. In our use case (running containers under VMs) these have proven to be critical. In particular, stat_to_qid in hw/9pfs/9p