Re: [Qemu-devel] [RFC] qapi: qapi-commands: fix possible leaks on visitor dealloc

2013-07-12 Thread Laszlo Ersek
On 07/11/13 21:14, Eric Blake wrote: > On 07/11/2013 12:50 PM, Luiz Capitulino wrote: >> I'm sending this as an RFC because this is untested, and also because >> I'm wondering if I'm seeing things after a long patch review session. > > I can't say that I tested it either, but... > >> >> The probl

Re: [Qemu-devel] [RFC] qapi: qapi-commands: fix possible leaks on visitor dealloc

2013-07-11 Thread Luiz Capitulino
On Thu, 11 Jul 2013 13:14:21 -0600 Eric Blake wrote: > On 07/11/2013 12:50 PM, Luiz Capitulino wrote: > > I'm sending this as an RFC because this is untested, and also because > > I'm wondering if I'm seeing things after a long patch review session. > > I can't say that I tested it either, but..

Re: [Qemu-devel] [RFC] qapi: qapi-commands: fix possible leaks on visitor dealloc

2013-07-11 Thread Eric Blake
On 07/11/2013 12:50 PM, Luiz Capitulino wrote: > I'm sending this as an RFC because this is untested, and also because > I'm wondering if I'm seeing things after a long patch review session. I can't say that I tested it either, but... > > The problem is: in qmp-marshal.c, the dealloc visitor cal

[Qemu-devel] [RFC] qapi: qapi-commands: fix possible leaks on visitor dealloc

2013-07-11 Thread Luiz Capitulino
I'm sending this as an RFC because this is untested, and also because I'm wondering if I'm seeing things after a long patch review session. The problem is: in qmp-marshal.c, the dealloc visitor calls use the same errp pointer of the input visitor calls. This means that if any of the input visitor