Re: [Qemu-devel] [RFC] generic-gpio-led & stm32-gpio-led

2015-06-17 Thread Liviu Ionescu
> On 17 Jun 2015, at 03:25, Peter Crosthwaite > wrote: > >> ... >> connecting a gpio_out to a gpio_in seems not possible, gpio_in irqs are >> parented to the device and parenting them to the gpio_out fail with the >> parent != 0 assertion. >> > > This should work. Can I see the backtrace of

Re: [Qemu-devel] [RFC] generic-gpio-led & stm32-gpio-led

2015-06-16 Thread Peter Crosthwaite
On Tue, Jun 16, 2015 at 3:25 PM, Liviu Ionescu wrote: > >> On 16 Jun 2015, at 19:10, Peter Crosthwaite >> wrote: >> >> ... In my proposal the machine model would do this. >> >> qdev_connect_gpio_out_named(mcu, "name", index, qdev_get_gpio_in(gpio_dev, >> 0)); >> >> Or something like that. > > c

Re: [Qemu-devel] [RFC] generic-gpio-led & stm32-gpio-led

2015-06-16 Thread Liviu Ionescu
> On 16 Jun 2015, at 19:10, Peter Crosthwaite > wrote: > > ... In my proposal the machine model would do this. > > qdev_connect_gpio_out_named(mcu, "name", index, qdev_get_gpio_in(gpio_dev, > 0)); > > Or something like that. connecting a gpio_out to a gpio_in seems not possible, gpio_in irq

Re: [Qemu-devel] [RFC] generic-gpio-led & stm32-gpio-led

2015-06-16 Thread Peter Crosthwaite
On Tue, Jun 16, 2015 at 12:22 PM, Liviu Ionescu wrote: > >> On 16 Jun 2015, at 21:19, Peter Crosthwaite >> wrote: >> >> Your autoformatter does a surprisingly good job of getting close to >> qemu coding style. Can the rules just be tweaked any maybe QEMU coding >> style can be added to eclipse?

Re: [Qemu-devel] [RFC] generic-gpio-led & stm32-gpio-led

2015-06-16 Thread Liviu Ionescu
> On 16 Jun 2015, at 21:19, Peter Crosthwaite > wrote: > > Your autoformatter does a surprisingly good job of getting close to > qemu coding style. Can the rules just be tweaked any maybe QEMU coding > style can be added to eclipse? this is exactly what I did, I took the K&R and tweaked it whe

Re: [Qemu-devel] [RFC] generic-gpio-led & stm32-gpio-led

2015-06-16 Thread Peter Crosthwaite
On Tue, Jun 16, 2015 at 10:16 AM, Liviu Ionescu wrote: > >> On 16 Jun 2015, at 19:10, Peter Crosthwaite >> wrote: >> >>> +bool use_stderr; >> >> Why do you want to switch between stderr and stdout? > > I wasn't sure which one is more appropriate, I first used stdout then tried > stderr. > >

Re: [Qemu-devel] [RFC] generic-gpio-led & stm32-gpio-led

2015-06-16 Thread Liviu Ionescu
> On 16 Jun 2015, at 19:10, Peter Crosthwaite > wrote: > >> +bool use_stderr; > > Why do you want to switch between stderr and stdout? I wasn't sure which one is more appropriate, I first used stdout then tried stderr. > I think stderr is more correct, yes, that was my conclusion too.

Re: [Qemu-devel] [RFC] generic-gpio-led & stm32-gpio-led

2015-06-16 Thread Peter Crosthwaite
On Tue, Jun 16, 2015 at 7:15 AM, Liviu Ionescu wrote: > # Intro > > For my multiple Cortex-M boards, I need a LED device that will display a > message when a GPIO bit is written. > > # Goal > > The goal is to pack the LED into an object that is very easy to instantiate > and configure. > > # Sol

[Qemu-devel] [RFC] generic-gpio-led & stm32-gpio-led

2015-06-16 Thread Liviu Ionescu
# Intro For my multiple Cortex-M boards, I need a LED device that will display a message when a GPIO bit is written. # Goal The goal is to pack the LED into an object that is very easy to instantiate and configure. # Solution My solution is an abstract class "generic-gpio-led" and derived cl