Re: [Qemu-devel] [RFC] exec: eliminate ram naming issue as migration

2018-02-28 Thread Igor Mammedov
in; qemu-devel@nongnu.org; > > Michael S . Tsirkin > > Subject: Re: [Qemu-devel] [RFC] exec: eliminate ram naming issue as > > migration > > > > On Sat, 24 Feb 2018 03:11:30 + > > "Tan, Jianfeng" wrote: > > > > > > -Origina

Re: [Qemu-devel] [RFC] exec: eliminate ram naming issue as migration

2018-02-26 Thread Tan, Jianfeng
> -Original Message- > From: Paolo Bonzini [mailto:pbonz...@redhat.com] > Sent: Monday, February 26, 2018 10:43 PM > To: Igor Mammedov; Tan, Jianfeng > Cc: Jason Wang; Maxime Coquelin; qemu-devel@nongnu.org; Michael S . > Tsirkin > Subject: Re: [Qemu-devel] [RFC

Re: [Qemu-devel] [RFC] exec: eliminate ram naming issue as migration

2018-02-26 Thread Tan, Jianfeng
: 'Igor Mammedov' > > > Cc: Paolo Bonzini; Jason Wang; Maxime Coquelin; qemu- > de...@nongnu.org; > > > Michael S . Tsirkin > > > Subject: RE: [Qemu-devel] [RFC] exec: eliminate ram naming issue as > > > migration > > > > > > Hi Igor and al

Re: [Qemu-devel] [RFC] exec: eliminate ram naming issue as migration

2018-02-26 Thread Paolo Bonzini
On 26/02/2018 13:55, Igor Mammedov wrote: >>> So how about just adding a new option --mem-share to decide if that's a >>> private memory or shared memory? That seems much straightforward way > Above options are legacy (which we can't remove for compat reasons), > their replacement is 'memory-backen

Re: [Qemu-devel] [RFC] exec: eliminate ram naming issue as migration

2018-02-26 Thread Igor Mammedov
el@nongnu.org; > > Michael S . Tsirkin > > Subject: RE: [Qemu-devel] [RFC] exec: eliminate ram naming issue as > > migration > > > > Hi Igor and all, > > > > > -Original Message- > > > From: Igor Mammedov [mailto:imamm...@redhat.com] &g

Re: [Qemu-devel] [RFC] exec: eliminate ram naming issue as migration

2018-02-23 Thread Tan, Jianfeng
> -Original Message- > From: Tan, Jianfeng > Sent: Saturday, February 24, 2018 11:08 AM > To: 'Igor Mammedov' > Cc: Paolo Bonzini; Jason Wang; Maxime Coquelin; qemu-devel@nongnu.org; > Michael S . Tsirkin > Subject: RE: [Qemu-devel] [RFC] exec: eliminate

Re: [Qemu-devel] [RFC] exec: eliminate ram naming issue as migration

2018-02-23 Thread Tan, Jianfeng
emu-devel] [RFC] exec: eliminate ram naming issue as > migration > [...] > > > It could be solved by adding memdev option to machine, > > > which would allow to specify backend object. And then on > > > top make -mem-path alias new option to clean thing up. > &

Re: [Qemu-devel] [RFC] exec: eliminate ram naming issue as migration

2018-02-08 Thread Igor Mammedov
t; >>>>> To: Igor Mammedov > >>>>> Cc: Tan, Jianfeng; qemu-devel@nongnu.org; Jason Wang; Maxime Coquelin; > >>>>> Michael S . Tsirkin > >>>>> Subject: Re: [Qemu-devel] [RFC] exec: eliminate ram naming issue as > >>

Re: [Qemu-devel] [RFC] exec: eliminate ram naming issue as migration

2018-02-08 Thread Tan, Jianfeng
...@redhat.com] Sent: Tuesday, February 6, 2018 1:32 AM To: Igor Mammedov Cc: Tan, Jianfeng; qemu-devel@nongnu.org; Jason Wang; Maxime Coquelin; Michael S . Tsirkin Subject: Re: [Qemu-devel] [RFC] exec: eliminate ram naming issue as migration On 05/02/2018 18:15, Igor Mammedov wrote: Then we would have

Re: [Qemu-devel] [RFC] exec: eliminate ram naming issue as migration

2018-02-08 Thread Igor Mammedov
zini [mailto:pbonz...@redhat.com] > >>> Sent: Tuesday, February 6, 2018 1:32 AM > >>> To: Igor Mammedov > >>> Cc: Tan, Jianfeng; qemu-devel@nongnu.org; Jason Wang; Maxime Coquelin; > >>> Michael S . Tsirkin > >>> Subject: Re: [Qemu-devel] [RFC]

Re: [Qemu-devel] [RFC] exec: eliminate ram naming issue as migration

2018-02-07 Thread Tan, Jianfeng
Jason Wang; Maxime Coquelin; Michael S . Tsirkin Subject: Re: [Qemu-devel] [RFC] exec: eliminate ram naming issue as migration On 05/02/2018 18:15, Igor Mammedov wrote: Then we would have both ram block named pc.ram: Block NamePSize pc.ram 4 KiB /obje

Re: [Qemu-devel] [RFC] exec: eliminate ram naming issue as migration

2018-02-07 Thread Igor Mammedov
son Wang; Maxime Coquelin; > > Michael S . Tsirkin > > Subject: Re: [Qemu-devel] [RFC] exec: eliminate ram naming issue as > > migration > > > > On 05/02/2018 18:15, Igor Mammedov wrote: > > >>> > > >>> Then we would have both ram bloc

Re: [Qemu-devel] [RFC] exec: eliminate ram naming issue as migration

2018-02-06 Thread Tan, Jianfeng
> -Original Message- > From: Paolo Bonzini [mailto:pbonz...@redhat.com] > Sent: Tuesday, February 6, 2018 1:32 AM > To: Igor Mammedov > Cc: Tan, Jianfeng; qemu-devel@nongnu.org; Jason Wang; Maxime Coquelin; > Michael S . Tsirkin > Subject: Re: [Qemu-devel] [RFC

Re: [Qemu-devel] [RFC] exec: eliminate ram naming issue as migration

2018-02-06 Thread Igor Mammedov
On Mon, 5 Feb 2018 18:36:31 + "Dr. David Alan Gilbert" wrote: > * Tan, Jianfeng (jianfeng@intel.com) wrote: > > > > > > On 2/6/2018 12:29 AM, Igor Mammedov wrote: > > > On Mon, 5 Feb 2018 14:58:55 + > > > Jianfeng Tan wrote: > > > > > > > Existing VMs with virtio devices and

Re: [Qemu-devel] [RFC] exec: eliminate ram naming issue as migration

2018-02-05 Thread Dr. David Alan Gilbert
* Igor Mammedov (imamm...@redhat.com) wrote: > On Mon, 5 Feb 2018 17:19:09 +0100 > Paolo Bonzini wrote: > > > On 05/02/2018 17:12, Tan, Jianfeng wrote: > > > Hi Paolo, > > > > > > On 2/5/2018 11:53 PM, Paolo Bonzini wrote: > > >> On 05/02/2018 15:58, Jianfeng Tan wrote: > > >>> Here are some

Re: [Qemu-devel] [RFC] exec: eliminate ram naming issue as migration

2018-02-05 Thread Dr. David Alan Gilbert
* Tan, Jianfeng (jianfeng@intel.com) wrote: > > > On 2/6/2018 12:29 AM, Igor Mammedov wrote: > > On Mon, 5 Feb 2018 14:58:55 + > > Jianfeng Tan wrote: > > > > > Existing VMs with virtio devices and vhost-kernel as the backend > > > are always started with mem config: > > > > > >"-

Re: [Qemu-devel] [RFC] exec: eliminate ram naming issue as migration

2018-02-05 Thread Paolo Bonzini
On 05/02/2018 17:44, Tan, Jianfeng wrote: >>> >> I understand.  However it's not as bad as "there's no possibility at all >> to migrate from vhost-kernel to vhost-user".  There are cases that are >> more problematic: for example, there's no possibility at all to add >> memory NUMA policy during a l

Re: [Qemu-devel] [RFC] exec: eliminate ram naming issue as migration

2018-02-05 Thread Igor Mammedov
On Mon, 5 Feb 2018 14:58:55 + Jianfeng Tan wrote: > Existing VMs with virtio devices and vhost-kernel as the backend > are always started with mem config: > > "-m xG" > (with a ram block named "pc.ram") > > while new VMs with virtio devices and vhost-user as the backend > are always st

Re: [Qemu-devel] [RFC] exec: eliminate ram naming issue as migration

2018-02-05 Thread Paolo Bonzini
On 05/02/2018 18:15, Igor Mammedov wrote: >>> >>> Then we would have both ram block named pc.ram: >>>   Block Name    PSize >>>   pc.ram 4 KiB >>>   /objects/pc.ram    2 MiB >>> >>> But I assume it's a corner case which not really happen. >> Yeah, you're ri

Re: [Qemu-devel] [RFC] exec: eliminate ram naming issue as migration

2018-02-05 Thread Igor Mammedov
On Mon, 5 Feb 2018 17:19:09 +0100 Paolo Bonzini wrote: > On 05/02/2018 17:12, Tan, Jianfeng wrote: > > Hi Paolo, > > > > On 2/5/2018 11:53 PM, Paolo Bonzini wrote: > >> On 05/02/2018 15:58, Jianfeng Tan wrote: > >>> Here are some options to fix this: > >>> > >>> 1. When we do ram name compar

Re: [Qemu-devel] [RFC] exec: eliminate ram naming issue as migration

2018-02-05 Thread Paolo Bonzini
On 05/02/2018 15:58, Jianfeng Tan wrote: > Here are some options to fix this: > > 1. When we do ram name comparison, we truncate the prefix as this patch shows. > It cannot cover the corner case: the source VM could have two ram blocks > with name of "pc.ram" and "/object/pc.ram". That shouldn't

Re: [Qemu-devel] [RFC] exec: eliminate ram naming issue as migration

2018-02-05 Thread Tan, Jianfeng
On 2/6/2018 12:19 AM, Paolo Bonzini wrote: On 05/02/2018 17:12, Tan, Jianfeng wrote: Hi Paolo, On 2/5/2018 11:53 PM, Paolo Bonzini wrote: On 05/02/2018 15:58, Jianfeng Tan wrote: Here are some options to fix this: 1. When we do ram name comparison, we truncate the prefix as this patch show

Re: [Qemu-devel] [RFC] exec: eliminate ram naming issue as migration

2018-02-05 Thread Paolo Bonzini
On 05/02/2018 17:12, Tan, Jianfeng wrote: > Hi Paolo, > > On 2/5/2018 11:53 PM, Paolo Bonzini wrote: >> On 05/02/2018 15:58, Jianfeng Tan wrote: >>> Here are some options to fix this: >>> >>> 1. When we do ram name comparison, we truncate the prefix as this >>> patch shows. >>> It cannot cover the

Re: [Qemu-devel] [RFC] exec: eliminate ram naming issue as migration

2018-02-05 Thread Tan, Jianfeng
On 2/6/2018 12:29 AM, Igor Mammedov wrote: On Mon, 5 Feb 2018 14:58:55 + Jianfeng Tan wrote: Existing VMs with virtio devices and vhost-kernel as the backend are always started with mem config: "-m xG" (with a ram block named "pc.ram") while new VMs with virtio devices and vhost

Re: [Qemu-devel] [RFC] exec: eliminate ram naming issue as migration

2018-02-05 Thread Tan, Jianfeng
Hi Paolo, On 2/5/2018 11:53 PM, Paolo Bonzini wrote: On 05/02/2018 15:58, Jianfeng Tan wrote: Here are some options to fix this: 1. When we do ram name comparison, we truncate the prefix as this patch shows. It cannot cover the corner case: the source VM could have two ram blocks with name of

Re: [Qemu-devel] [RFC] exec: eliminate ram naming issue as migration

2018-02-05 Thread no-reply
: eliminate ram naming issue as migration === TEST SCRIPT BEGIN === #!/bin/bash set -e git submodule update --init dtc # Let docker tests dump environment info export SHOW_ENV=1 export J=8 time make docker-test-mingw@fedora === TEST SCRIPT END === Updating 3c8cf5a9c21ff8782164d1def7f44bd888713384

Re: [Qemu-devel] [RFC] exec: eliminate ram naming issue as migration

2018-02-05 Thread no-reply
Hi, This series seems to have some coding style problems. See output below for more information: Type: series Message-id: 1517842735-9011-1-git-send-email-jianfeng@intel.com Subject: [Qemu-devel] [RFC] exec: eliminate ram naming issue as migration === TEST SCRIPT BEGIN === #!/bin/bash BASE

[Qemu-devel] [RFC] exec: eliminate ram naming issue as migration

2018-02-05 Thread Jianfeng Tan
Existing VMs with virtio devices and vhost-kernel as the backend are always started with mem config: "-m xG" (with a ram block named "pc.ram") while new VMs with virtio devices and vhost-user as the backend are always started with mem config: "-m xG -numa node,memdev=pc.ram -object memory-