Re: [Qemu-devel] [RFC] contrib: add vhost-user-sim

2019-10-09 Thread Johannes Berg
On Wed, 2019-10-09 at 15:00 +0100, Stefan Hajnoczi wrote: > > The first issue is that sometimes glib actually seems to reports an FD > > as readable when it's not, so I even put them into non-blocking mode :( > > Strange. Spurious wakeups are possible in general. I think when using > fd monitor

Re: [Qemu-devel] [RFC] contrib: add vhost-user-sim

2019-10-09 Thread Stefan Hajnoczi
On Mon, Sep 23, 2019 at 11:33:41AM +0200, Johannes Berg wrote: > On Mon, 2019-09-23 at 10:25 +0100, Stefan Hajnoczi wrote: > Note, I'm not happy with this code at all, it deadlocks all the time. > Unfortunately I haven't really been able to figure out how to make glib > do what I wanted. > > The f

Re: [Qemu-devel] [RFC] contrib: add vhost-user-sim

2019-09-23 Thread Johannes Berg
On Mon, 2019-09-23 at 10:25 +0100, Stefan Hajnoczi wrote: > > According to unix(7): > > The addrlen argument that describes the enclosing sockaddr_un > structure should have a value of at least: > > offsetof(struct sockaddr_un, sun_path)+strlen(addr.sun_path)+1 > > or, more simply, ad

Re: [Qemu-devel] [RFC] contrib: add vhost-user-sim

2019-09-23 Thread Stefan Hajnoczi
On Tue, Sep 17, 2019 at 02:26:44PM +0200, Johannes Berg wrote: > +static int unix_sock_new(const char *unix_fn) > +{ > +int sock; > +struct sockaddr_un un; > +size_t len; > + > +g_assert(unix_fn); > + > +sock = socket(AF_UNIX, SOCK_STREAM, 0); > +if (sock <= 0) { > +

Re: [Qemu-devel] [RFC] contrib: add vhost-user-sim

2019-09-17 Thread no-reply
Patchew URL: https://patchew.org/QEMU/20190917122644.15736-1-johan...@sipsolutions.net/ Hi, This series failed the docker-mingw@fedora build test. Please find the testing commands and their output below. If you have Docker installed, you can probably reproduce it locally. === TEST SCRIPT BEG

Re: [Qemu-devel] [RFC] contrib: add vhost-user-sim

2019-09-17 Thread no-reply
Patchew URL: https://patchew.org/QEMU/20190917122644.15736-1-johan...@sipsolutions.net/ Hi, This series failed the asan build test. Please find the testing commands and their output below. If you have Docker installed, you can probably reproduce it locally. === TEST SCRIPT BEGIN === #!/bin/ba

Re: [Qemu-devel] [RFC] contrib: add vhost-user-sim

2019-09-17 Thread no-reply
Patchew URL: https://patchew.org/QEMU/20190917122644.15736-1-johan...@sipsolutions.net/ Hi, This series seems to have some coding style problems. See output below for more information: Subject: [Qemu-devel] [RFC] contrib: add vhost-user-sim Message-id: 20190917122644.15736-1-johan

[Qemu-devel] [RFC] contrib: add vhost-user-sim

2019-09-17 Thread Johannes Berg
From: Johannes Berg This implements * the UM protocol to access the simulation calendar, * the underlying simulation calendar, and * a very trivial simulated network as a vhost-user virtio_net device. Currently the code is a bit rough and mostly an example, things such as the network propa