Re: [Qemu-devel] [RFC] Using BlockdevRef in the block layer

2013-12-06 Thread Max Reitz
On 06.12.2013 12:14, Max Reitz wrote: On 06.12.2013 12:00, Max Reitz wrote: On 06.12.2013 11:43, Kevin Wolf wrote: Am 05.12.2013 um 18:41 hat Max Reitz geschrieben: When trying to implement this, I hit the problem that BlockdevRef allows you to reference an existing block device; however, this

Re: [Qemu-devel] [RFC] Using BlockdevRef in the block layer

2013-12-06 Thread Max Reitz
On 06.12.2013 12:00, Max Reitz wrote: On 06.12.2013 11:43, Kevin Wolf wrote: Am 05.12.2013 um 18:41 hat Max Reitz geschrieben: When trying to implement this, I hit the problem that BlockdevRef allows you to reference an existing block device; however, this seems currently unimplemented. This is

Re: [Qemu-devel] [RFC] Using BlockdevRef in the block layer

2013-12-06 Thread Max Reitz
On 06.12.2013 11:45, Kevin Wolf wrote: Am 05.12.2013 um 19:35 hat Max Reitz geschrieben: On 05.12.2013 18:41, Max Reitz wrote: […] Second, if specifying a reference to an existing device should really be supported, bdrv_open() should ideally not call bdrv_file_open() anymore, but a function bd

Re: [Qemu-devel] [RFC] Using BlockdevRef in the block layer

2013-12-06 Thread Max Reitz
On 06.12.2013 11:43, Kevin Wolf wrote: Am 05.12.2013 um 18:41 hat Max Reitz geschrieben: When trying to implement this, I hit the problem that BlockdevRef allows you to reference an existing block device; however, this seems currently unimplemented. This is further hindered by the fact how this

Re: [Qemu-devel] [RFC] Using BlockdevRef in the block layer

2013-12-06 Thread Kevin Wolf
Am 05.12.2013 um 19:35 hat Max Reitz geschrieben: > On 05.12.2013 18:41, Max Reitz wrote: > >[…] > > > >Second, if specifying a reference to an existing device should > >really be supported, bdrv_open() should ideally not call > >bdrv_file_open() anymore, but a function bdrv_find_ref() instead > >w

Re: [Qemu-devel] [RFC] Using BlockdevRef in the block layer

2013-12-06 Thread Kevin Wolf
Am 05.12.2013 um 18:41 hat Max Reitz geschrieben: > When trying to implement this, I hit the problem that BlockdevRef > allows you to reference an existing block device; however, this > seems currently unimplemented. This is further hindered by the fact > how this reference is done: If you want to

Re: [Qemu-devel] [RFC] Using BlockdevRef in the block layer

2013-12-05 Thread Max Reitz
On 05.12.2013 19:35, Max Reitz wrote: On 05.12.2013 18:41, Max Reitz wrote: […] Second, if specifying a reference to an existing device should really be supported, bdrv_open() should ideally not call bdrv_file_open() anymore, but a function bdrv_find_ref() instead which resolves a BlockdevRe

Re: [Qemu-devel] [RFC] Using BlockdevRef in the block layer

2013-12-05 Thread Max Reitz
On 05.12.2013 18:41, Max Reitz wrote: […] Second, if specifying a reference to an existing device should really be supported, bdrv_open() should ideally not call bdrv_file_open() anymore, but a function bdrv_find_ref() instead which resolves a BlockdevRef structure (for simplicity, it appears

[Qemu-devel] [RFC] Using BlockdevRef in the block layer

2013-12-05 Thread Max Reitz
Hi everyone, Quite recently, I sent a series to qemu-devel which allowed it to use blkdebug and blkverify in some kind of a “native” QMP mode; that is, there was no need to parse the filename anymore, instead everything could be passed through the blockdev options. The image filename could e