Re: [Qemu-devel] [RFC] RFC on Backup tool

2017-07-21 Thread Alex Bennée
Ishani writes: > Thanks for the review. > > - On Jul 17, 2017, at 12:48 PM, Fam Zheng f...@redhat.com wrote: > >> On Sun, 07/16 02:13, Ishani Chugh wrote: >>> This is a Request For Comments patch for qemu backup tool. As an >>> Outreachy intern, I am assigned to the project for creating a ba

Re: [Qemu-devel] [RFC] RFC on Backup tool

2017-07-21 Thread Stefan Hajnoczi
On Tue, Jul 18, 2017 at 05:29:11PM -0400, John Snow wrote: > > > On 07/17/2017 03:37 PM, Ishani wrote: > > - On Jul 17, 2017, at 12:48 PM, Fam Zheng f...@redhat.com wrote: > >> On Sun, 07/16 02:13, Ishani Chugh wrote: > > [...] > > >> Only full backup is implemented in this patch, is the pl

Re: [Qemu-devel] [RFC] RFC on Backup tool

2017-07-20 Thread Ishani
- On Jul 17, 2017, at 8:02 PM, stefanha stefa...@redhat.com wrote: > On Sun, Jul 16, 2017 at 02:13:21AM +0530, Ishani Chugh wrote: >> +def write_config(self): >> +""" >> +Writes configuration to ini file. >> +""" >> +with open(self.config_file, 'w') as confi

Re: [Qemu-devel] [RFC] RFC on Backup tool

2017-07-20 Thread Ishani
- On Jul 19, 2017, at 2:59 AM, jsnow js...@redhat.com wrote: > On 07/17/2017 03:37 PM, Ishani wrote: >> - On Jul 17, 2017, at 12:48 PM, Fam Zheng f...@redhat.com wrote: >>> On Sun, 07/16 02:13, Ishani Chugh wrote: > > [...] > >>> Only full backup is implemented in this patch, is the pl

Re: [Qemu-devel] [RFC] RFC on Backup tool

2017-07-18 Thread Eric Blake
On 07/18/2017 04:29 PM, John Snow wrote: >>> >>> You need a copyright header here (the default choice for QEMU is GPLv2 but >>> there >>> is no strict restrictions for scripts). See examples in other *.py files. >> >> Thanks. Will update in next revision. >> > > Yes, up to you. Files without a

Re: [Qemu-devel] [RFC] RFC on Backup tool

2017-07-18 Thread John Snow
On 07/17/2017 03:37 PM, Ishani wrote: > - On Jul 17, 2017, at 12:48 PM, Fam Zheng f...@redhat.com wrote: >> On Sun, 07/16 02:13, Ishani Chugh wrote: [...] >> Only full backup is implemented in this patch, is the plan to add incremental >> backup on top? I'm curious because you have target

Re: [Qemu-devel] [RFC] RFC on Backup tool

2017-07-17 Thread Ishani
Thanks for the review. - On Jul 17, 2017, at 12:48 PM, Fam Zheng f...@redhat.com wrote: > On Sun, 07/16 02:13, Ishani Chugh wrote: >> This is a Request For Comments patch for qemu backup tool. As an >> Outreachy intern, I am assigned to the project for creating a backup >> tool. qemu-backup

Re: [Qemu-devel] [RFC] RFC on Backup tool

2017-07-17 Thread Stefan Hajnoczi
On Sun, Jul 16, 2017 at 02:13:21AM +0530, Ishani Chugh wrote: > +def write_config(self): > +""" > +Writes configuration to ini file. > +""" > +with open(self.config_file, 'w') as config_file: > +self.config.write(config_file) Please update the config

Re: [Qemu-devel] [RFC] RFC on Backup tool

2017-07-17 Thread Stefan Hajnoczi
On Mon, Jul 17, 2017 at 03:18:35PM +0800, Fam Zheng wrote: > On Sun, 07/16 02:13, Ishani Chugh wrote: > > +""" > > +This file is an implementation of backup tool > > +""" > > +from argparse import ArgumentParser > > +import os > > +import errno > > +from socket import error as socket_error > > +imp

Re: [Qemu-devel] [RFC] RFC on Backup tool

2017-07-17 Thread Fam Zheng
On Sun, 07/16 02:13, Ishani Chugh wrote: > This is a Request For Comments patch for qemu backup tool. As an > Outreachy intern, I am assigned to the project for creating a backup > tool. qemu-backup will be a command-line tool for performing full and > incremental disk backups on running VMs. Onl

[Qemu-devel] [RFC] RFC on Backup tool

2017-07-15 Thread Ishani Chugh
This is a Request For Comments patch for qemu backup tool. As an Outreachy intern, I am assigned to the project for creating a backup tool. qemu-backup will be a command-line tool for performing full and incremental disk backups on running VMs. It is intended as a reference implementation for manag