Re: [Qemu-devel] [RFC] Proposal for hw/ split

2013-03-12 Thread Paolo Bonzini
Il 12/03/2013 07:48, Richard Henderson ha scritto: > On 2013-03-11 04:17, Paolo Bonzini wrote: >> == hw/pci == >> hw/alpha_typhoon.c hw/pci/host-typhoon.c > > Why wouldn't this go into hw/alpha/, really? Sure. I think the Alpha-specific interrupt delivery parts should b

Re: [Qemu-devel] [RFC] Proposal for hw/ split

2013-03-11 Thread Richard Henderson
On 2013-03-11 04:17, Paolo Bonzini wrote: == hw/pci == hw/alpha_typhoon.c hw/pci/host-typhoon.c Why wouldn't this go into hw/alpha/, really? r~

Re: [Qemu-devel] [RFC] Proposal for hw/ split

2013-03-11 Thread Stefan Hajnoczi
On Mon, Mar 11, 2013 at 12:17:20PM +0100, Paolo Bonzini wrote: > hw/dataplane/Makefile.objs hw/block/dataplane/Makefile.objs > hw/dataplane/hostmem.c hw/block/dataplane/hostmem.c > hw/dataplane/ioq.c hw/block/dataplane/ioq.c > hw/dat

Re: [Qemu-devel] [RFC] Proposal for hw/ split

2013-03-11 Thread Markus Armbruster
Peter Maydell writes: > On 11 March 2013 11:54, Paolo Bonzini wrote: >> Il 11/03/2013 12:31, Peter Maydell ha scritto: >>> On 11 March 2013 11:17, Paolo Bonzini wrote: hw/arm11mpcore.c hw/arm/arm11mpcore.c >>> >>> Two devices but I can split them if you insist.

Re: [Qemu-devel] [RFC] Proposal for hw/ split

2013-03-11 Thread Paolo Bonzini
Il 11/03/2013 14:08, Peter Maydell ha scritto: >>> These are little more than SoC containers, aren't they? >>> >> >>> >> They're container devices, yes. But why should container devices >>> >> go under hw/$ARCH ? >> > >> > Because they don't really implement any logic, ideally a board should b

Re: [Qemu-devel] [RFC] Proposal for hw/ split

2013-03-11 Thread Peter Maydell
On 11 March 2013 12:44, Paolo Bonzini wrote: > Il 11/03/2013 13:39, Peter Maydell ha scritto: >> On 11 March 2013 11:54, Paolo Bonzini wrote: >>> These are little more than SoC containers, aren't they? >> >> They're container devices, yes. But why should container devices >> go under hw/$ARCH ? >

Re: [Qemu-devel] [RFC] Proposal for hw/ split

2013-03-11 Thread Paolo Bonzini
Il 11/03/2013 13:39, Peter Maydell ha scritto: > On 11 March 2013 11:54, Paolo Bonzini wrote: >> Il 11/03/2013 12:31, Peter Maydell ha scritto: >>> On 11 March 2013 11:17, Paolo Bonzini wrote: hw/arm11mpcore.c hw/arm/arm11mpcore.c >>> >>> Two devices but I can spl

Re: [Qemu-devel] [RFC] Proposal for hw/ split

2013-03-11 Thread Paolo Bonzini
Il 11/03/2013 12:31, Peter Maydell ha scritto: > On 11 March 2013 11:17, Paolo Bonzini wrote: >> - Files go in hw/ARCH/ if they used to be in hw/ARCH/Makefile.objs and >> they define multiple devices (example: hw/arm/tc6393xb.c) > > Why are multiple devices in one file a bad thing (or at least,

Re: [Qemu-devel] [RFC] Proposal for hw/ split

2013-03-11 Thread Edgar E. Iglesias
On Mon, Mar 11, 2013 at 12:17:20PM +0100, Paolo Bonzini wrote: > The general ideas are (earlier rules override the later, and exceptions > are of course possible): > > - Board files go in hw/ARCH/ (already done). > > - Files go in hw/ARCH/ if they reference that arch's CPUState (already done) >

Re: [Qemu-devel] [RFC] Proposal for hw/ split

2013-03-11 Thread Peter Maydell
On 11 March 2013 11:17, Paolo Bonzini wrote: > - Files go in hw/ARCH/ if they used to be in hw/ARCH/Makefile.objs and > they define multiple devices (example: hw/arm/tc6393xb.c) Why are multiple devices in one file a bad thing (or at least, a thing that should determine where a file lives)? Sho

[Qemu-devel] [RFC] Proposal for hw/ split

2013-03-11 Thread Paolo Bonzini
The general ideas are (earlier rules override the later, and exceptions are of course possible): - Board files go in hw/ARCH/ (already done). - Files go in hw/ARCH/ if they reference that arch's CPUState (already done) - Files already in a subdirectory are not moved (examples: some PPC/S390 fi