Re: [Qemu-devel] [RFC] Introducing CoroCheck and proposal for a blocking_fn annotation

2013-09-06 Thread Gabriel Kerneis
On Fri, Sep 06, 2013 at 04:36:47PM +0100, Charlie Shepherd wrote: > However, I'm not sure it makes sense to use blocking_fn until the > convert-block series (which currently needs a respin after Stefan's > review) is fully upstreamed. Maybe this patch makes most sense at > the start of that series?

Re: [Qemu-devel] [RFC] Introducing CoroCheck and proposal for a blocking_fn annotation

2013-09-06 Thread Kevin Wolf
Am 06.09.2013 um 18:05 hat Gabriel Kerneis geschrieben: > On Fri, Sep 06, 2013 at 04:36:47PM +0100, Charlie Shepherd wrote: > > However, I'm not sure it makes sense to use blocking_fn until the > > convert-block series (which currently needs a respin after Stefan's > > review) is fully upstreamed.

Re: [Qemu-devel] [RFC] Introducing CoroCheck and proposal for a blocking_fn annotation

2013-09-06 Thread Charlie Shepherd
On 06/09/2013 15:30, Gabriel Kerneis wrote: Note that CoroCheck has been written as a plugin to CIL [5]. Contrary to CPC, which is still somewhat of a prototype (although a pretty good one!), CIL is a solid piece of software, packaged in both Fedora and (very soon) Debian. CoroCheck makes use of

Re: [Qemu-devel] [RFC] Introducing CoroCheck and proposal for a blocking_fn annotation

2013-09-06 Thread Gabriel Kerneis
On Fri, Sep 06, 2013 at 03:30:38PM +0100, Gabriel Kerneis wrote: > More precisely, here is what CoroCheck does for each file of QEMU: > - produce a .dot file that can be processed with graphviz to produce a > pdf of the annotated call graph (with wrong annotations showing up in > red - this sti

[Qemu-devel] [RFC] Introducing CoroCheck and proposal for a blocking_fn annotation

2013-09-06 Thread Gabriel Kerneis
During his GSoC on writing a CPC [1] backend for QEMU, Charlie Shepherd started to explicitly annotate coroutine_fn [2]. On aspect of this refactoring work has been to split "dynamic" functions (that used qemu_in_coroutine) into a blocking version and a coroutine one. It has been agreed that it was