Re: [Qemu-devel] [RFC] HACKING: Document 'struct' keyword usage

2019-08-02 Thread Thomas Huth
On 01/08/2019 21.23, Paolo Bonzini wrote: > On 01/08/19 20:50, Eduardo Habkost wrote: >> On Wed, Jul 31, 2019 at 10:35:31AM +0200, Thomas Huth wrote: >>> On 30/07/2019 23.07, Eduardo Habkost wrote: Sometimes we use the 'struct' keyword to help us reduce dependencies between header files.

Re: [Qemu-devel] [RFC] HACKING: Document 'struct' keyword usage

2019-08-01 Thread Paolo Bonzini
On 01/08/19 20:50, Eduardo Habkost wrote: > On Wed, Jul 31, 2019 at 10:35:31AM +0200, Thomas Huth wrote: >> On 30/07/2019 23.07, Eduardo Habkost wrote: >>> Sometimes we use the 'struct' keyword to help us reduce >>> dependencies between header files. Document that practice. >>> >>> Signed-off-by:

Re: [Qemu-devel] [RFC] HACKING: Document 'struct' keyword usage

2019-08-01 Thread Eduardo Habkost
On Wed, Jul 31, 2019 at 10:35:31AM +0200, Thomas Huth wrote: > On 30/07/2019 23.07, Eduardo Habkost wrote: > > Sometimes we use the 'struct' keyword to help us reduce > > dependencies between header files. Document that practice. > > > > Signed-off-by: Eduardo Habkost > > --- > > I wonder if thi

Re: [Qemu-devel] [RFC] HACKING: Document 'struct' keyword usage

2019-08-01 Thread Aleksandar Markovic
On Tue, Jul 30, 2019 at 11:07 PM Eduardo Habkost wrote: > Sometimes we use the 'struct' keyword to help us reduce > dependencies between header files. Document that practice. > > Signed-off-by: Eduardo Habkost > --- > I wonder if this is too terse? Should we give examples? > --- > I am inclin

Re: [Qemu-devel] [RFC] HACKING: Document 'struct' keyword usage

2019-07-31 Thread Thomas Huth
On 30/07/2019 23.07, Eduardo Habkost wrote: > Sometimes we use the 'struct' keyword to help us reduce > dependencies between header files. Document that practice. > > Signed-off-by: Eduardo Habkost > --- > I wonder if this is too terse? Should we give examples? > --- > HACKING | 2 ++ > 1 file

Re: [Qemu-devel] [RFC] HACKING: Document 'struct' keyword usage

2019-07-30 Thread Eric Blake
On 7/30/19 4:07 PM, Eduardo Habkost wrote: > Sometimes we use the 'struct' keyword to help us reduce > dependencies between header files. Document that practice. > > Signed-off-by: Eduardo Habkost > --- > I wonder if this is too terse? Should we give examples? An example might be nice, but I l

[Qemu-devel] [RFC] HACKING: Document 'struct' keyword usage

2019-07-30 Thread Eduardo Habkost
Sometimes we use the 'struct' keyword to help us reduce dependencies between header files. Document that practice. Signed-off-by: Eduardo Habkost --- I wonder if this is too terse? Should we give examples? --- HACKING | 2 ++ 1 file changed, 2 insertions(+) diff --git a/HACKING b/HACKING inde