Re: [Qemu-devel] [RFC] Device isolation infrastructure v2

2012-01-30 Thread David Gibson
On Wed, Jan 25, 2012 at 04:44:53PM -0700, Alex Williamson wrote: > On Wed, 2012-01-25 at 14:13 +1100, David Gibson wrote: > > On Tue, Dec 20, 2011 at 09:30:37PM -0700, Alex Williamson wrote: > > > On Wed, 2011-12-21 at 14:32 +1100, David Gibson wrote: > > > > On Mon, Dec 19, 2011 at 04:41:56PM +010

Re: [Qemu-devel] [RFC] Device isolation infrastructure v2

2012-01-25 Thread Alex Williamson
On Wed, 2012-01-25 at 14:13 +1100, David Gibson wrote: > On Tue, Dec 20, 2011 at 09:30:37PM -0700, Alex Williamson wrote: > > On Wed, 2011-12-21 at 14:32 +1100, David Gibson wrote: > > > On Mon, Dec 19, 2011 at 04:41:56PM +0100, Joerg Roedel wrote: > > > > On Mon, Dec 19, 2011 at 11:11:25AM +1100,

Re: [Qemu-devel] [RFC] Device isolation infrastructure v2

2012-01-24 Thread David Gibson
On Tue, Dec 20, 2011 at 09:30:37PM -0700, Alex Williamson wrote: > On Wed, 2011-12-21 at 14:32 +1100, David Gibson wrote: > > On Mon, Dec 19, 2011 at 04:41:56PM +0100, Joerg Roedel wrote: > > > On Mon, Dec 19, 2011 at 11:11:25AM +1100, David Gibson wrote: > > > > Well.. that's not where it is in Al

Re: [Qemu-devel] [RFC] Device isolation infrastructure v2

2011-12-21 Thread Joerg Roedel
On Wed, Dec 21, 2011 at 02:32:35PM +1100, David Gibson wrote: > On Mon, Dec 19, 2011 at 04:41:56PM +0100, Joerg Roedel wrote: > > For 1) I think the current solution with the iommu_group file is fine. > > It is somewhat expensive for user-space to figure out the per-group > > device-sets, but that

Re: [Qemu-devel] [RFC] Device isolation infrastructure v2

2011-12-20 Thread Aaron Fabbri
On 12/20/11 8:30 PM, "Alex Williamson" wrote: > On Wed, 2011-12-21 at 14:32 +1100, David Gibson wrote: >> On Mon, Dec 19, 2011 at 04:41:56PM +0100, Joerg Roedel wrote: >>> On Mon, Dec 19, 2011 at 11:11:25AM +1100, David Gibson wrote: >>> >>> Well, the iommu-api was designed for amd-vi and vt

Re: [Qemu-devel] [RFC] Device isolation infrastructure v2

2011-12-20 Thread Alex Williamson
On Wed, 2011-12-21 at 14:32 +1100, David Gibson wrote: > On Mon, Dec 19, 2011 at 04:41:56PM +0100, Joerg Roedel wrote: > > On Mon, Dec 19, 2011 at 11:11:25AM +1100, David Gibson wrote: > > > Well.. that's not where it is in Alex's code either. The iommu layer > > > (to the extent that there is suc

Re: [Qemu-devel] [RFC] Device isolation infrastructure v2

2011-12-20 Thread David Gibson
On Mon, Dec 19, 2011 at 04:41:56PM +0100, Joerg Roedel wrote: > On Mon, Dec 19, 2011 at 11:11:25AM +1100, David Gibson wrote: > > Well.. that's not where it is in Alex's code either. The iommu layer > > (to the extent that there is such a "layer") supplies the group info, > > but the group managem

Re: [Qemu-devel] [RFC] Device isolation infrastructure v2

2011-12-19 Thread David Gibson
On Mon, Dec 19, 2011 at 10:56:40PM +, David Woodhouse wrote: > On Tue, 2011-12-20 at 09:31 +1100, David Gibson wrote: > > When we're running paravirtualized under pHyp, it's impossible to > > merge multiple PEs into one domain per se. We could fake it rather > > nastily by replicating all map/

Re: [Qemu-devel] [RFC] Device isolation infrastructure v2

2011-12-19 Thread David Woodhouse
On Tue, 2011-12-20 at 09:31 +1100, David Gibson wrote: > When we're running paravirtualized under pHyp, it's impossible to > merge multiple PEs into one domain per se. We could fake it rather > nastily by replicating all map/unmaps across mutiple PEs. When > running bare metal, we could do so a b

Re: [Qemu-devel] [RFC] Device isolation infrastructure v2

2011-12-19 Thread David Gibson
On Mon, Dec 19, 2011 at 03:46:38PM +, David Woodhouse wrote: > On Mon, 2011-12-19 at 11:11 +1100, David Gibson wrote: > > They have no inbuilt concept > > of domains (though we could fake in software in some circumstances). > > That sentence doesn't make much sense to me. > > Either you're

Re: [Qemu-devel] [RFC] Device isolation infrastructure v2

2011-12-19 Thread David Woodhouse
On Mon, 2011-12-19 at 11:11 +1100, David Gibson wrote: > They have no inbuilt concept > of domains (though we could fake in software in some circumstances). That sentence doesn't make much sense to me. Either you're saying that every device behind a given IOMMU is in *one* domain (i.e. there's

Re: [Qemu-devel] [RFC] Device isolation infrastructure v2

2011-12-19 Thread Joerg Roedel
On Mon, Dec 19, 2011 at 11:11:25AM +1100, David Gibson wrote: > Well.. that's not where it is in Alex's code either. The iommu layer > (to the extent that there is such a "layer") supplies the group info, > but the group management is in vfio, not the iommu layer. With mine > it is in the driver

Re: [Qemu-devel] [RFC] Device isolation infrastructure v2

2011-12-18 Thread David Gibson
On Fri, Dec 16, 2011 at 03:53:53PM +0100, Joerg Roedel wrote: > On Thu, Dec 15, 2011 at 11:05:07AM -0700, Alex Williamson wrote: > > Starting with it in the core and hand waving some future use that we > > don't plan to implement right now seems like the wrong direction. > > I agree with Alex. Fir

Re: [Qemu-devel] [RFC] Device isolation infrastructure v2

2011-12-16 Thread Joerg Roedel
On Thu, Dec 15, 2011 at 11:05:07AM -0700, Alex Williamson wrote: > Starting with it in the core and hand waving some future use that we > don't plan to implement right now seems like the wrong direction. I agree with Alex. First of all, I havn't seen any real vfio problem that can't be solved with

Re: [Qemu-devel] [RFC] Device isolation infrastructure v2

2011-12-15 Thread David Gibson
On Thu, Dec 15, 2011 at 09:49:05PM -0700, Alex Williamson wrote: > On Fri, 2011-12-16 at 12:40 +1100, David Gibson wrote: > > On Thu, Dec 15, 2011 at 11:05:07AM -0700, Alex Williamson wrote: > > > On Thu, 2011-12-15 at 17:25 +1100, David Gibson wrote: > > > > Here's the second spin of my preferred

Re: [Qemu-devel] [RFC] Device isolation infrastructure v2

2011-12-15 Thread Alex Williamson
On Fri, 2011-12-16 at 12:40 +1100, David Gibson wrote: > On Thu, Dec 15, 2011 at 11:05:07AM -0700, Alex Williamson wrote: > > On Thu, 2011-12-15 at 17:25 +1100, David Gibson wrote: > > > Here's the second spin of my preferred approach to handling grouping > > > of devices for safe assignment to gue

Re: [Qemu-devel] [RFC] Device isolation infrastructure v2

2011-12-15 Thread David Gibson
On Thu, Dec 15, 2011 at 11:05:07AM -0700, Alex Williamson wrote: > On Thu, 2011-12-15 at 17:25 +1100, David Gibson wrote: > > Here's the second spin of my preferred approach to handling grouping > > of devices for safe assignment to guests. > > > > Changes since v1: > > * Many name changes and fi

Re: [Qemu-devel] [RFC] Device isolation infrastructure v2

2011-12-15 Thread Alex Williamson
On Thu, 2011-12-15 at 11:05 -0700, Alex Williamson wrote: > On Thu, 2011-12-15 at 17:25 +1100, David Gibson wrote: > > Here's the second spin of my preferred approach to handling grouping > > of devices for safe assignment to guests. > > > > Changes since v1: > > * Many name changes and file move

Re: [Qemu-devel] [RFC] Device isolation infrastructure v2

2011-12-15 Thread Alex Williamson
On Thu, 2011-12-15 at 17:25 +1100, David Gibson wrote: > Here's the second spin of my preferred approach to handling grouping > of devices for safe assignment to guests. > > Changes since v1: > * Many name changes and file moves for improved consistency > * Bugfixes and cleanups > * The interfa

[Qemu-devel] [RFC] Device isolation infrastructure v2

2011-12-14 Thread David Gibson
Here's the second spin of my preferred approach to handling grouping of devices for safe assignment to guests. Changes since v1: * Many name changes and file moves for improved consistency * Bugfixes and cleanups * The interface to the next layer up is considerably fleshed out, although it s