Re: [Qemu-devel] [RFC][PATCH v3 01/21] virtproxy: base data structures and constants

2010-11-18 Thread Jes Sorensen
On 11/18/10 16:56, Anthony Liguori wrote: > On 11/18/2010 09:51 AM, Jes Sorensen wrote: >>> Yes, I think Jes was just looking for an excuse to say "typedefmeharder" >>> :-) >>> >> Actually typedefs are not listed as a must do thing in CODING_STYLE, >> fortunately! > > That's a bug in CODING_

Re: [Qemu-devel] [RFC][PATCH v3 01/21] virtproxy: base data structures and constants

2010-11-18 Thread Anthony Liguori
On 11/18/2010 09:51 AM, Jes Sorensen wrote: Yes, I think Jes was just looking for an excuse to say "typedefmeharder" :-) Actually typedefs are not listed as a must do thing in CODING_STYLE, fortunately! That's a bug in CODING_STYLE. typedefing structures is one of the core characteristi

Re: [Qemu-devel] [RFC][PATCH v3 01/21] virtproxy: base data structures and constants

2010-11-18 Thread Jes Sorensen
On 11/18/10 16:41, Anthony Liguori wrote: > On 11/18/2010 09:35 AM, Michael Roth wrote: +/* listening fd, one for each service we're forwarding to remote end */ +typedef struct VPOForward { +VPDriver *drv; +int listen_fd; +char service_id[VP_SERVICE_ID_LEN]

Re: [Qemu-devel] [RFC][PATCH v3 01/21] virtproxy: base data structures and constants

2010-11-18 Thread Anthony Liguori
On 11/18/2010 09:35 AM, Michael Roth wrote: +/* listening fd, one for each service we're forwarding to remote end */ +typedef struct VPOForward { +VPDriver *drv; +int listen_fd; +char service_id[VP_SERVICE_ID_LEN]; +QLIST_ENTRY(VPOForward) next; +} VPOForward; I am really not a

Re: [Qemu-devel] [RFC][PATCH v3 01/21] virtproxy: base data structures and constants

2010-11-18 Thread Michael Roth
On 11/18/2010 05:06 AM, Jes Sorensen wrote: On 11/16/10 02:15, Michael Roth wrote: Signed-off-by: Michael Roth --- virtproxy.c | 136 +++ virtproxy.h | 34 +++ 2 files changed, 170 insertions(+), 0 deletions(-) create m

Re: [Qemu-devel] [RFC][PATCH v3 01/21] virtproxy: base data structures and constants

2010-11-18 Thread Jes Sorensen
On 11/16/10 02:15, Michael Roth wrote: > Signed-off-by: Michael Roth > --- > virtproxy.c | 136 > +++ > virtproxy.h | 34 +++ > 2 files changed, 170 insertions(+), 0 deletions(-) > create mode 100644 virtproxy.c > create mo

[Qemu-devel] [RFC][PATCH v3 01/21] virtproxy: base data structures and constants

2010-11-15 Thread Michael Roth
Signed-off-by: Michael Roth --- virtproxy.c | 136 +++ virtproxy.h | 34 +++ 2 files changed, 170 insertions(+), 0 deletions(-) create mode 100644 virtproxy.c create mode 100644 virtproxy.h diff --git a/virtproxy.c b/virtp