Re: [Qemu-devel] [RFC][PATCH v2]Add timestamp to error message

2013-05-02 Thread Seiji Aguchi
ji Aguchi; > stefa...@redhat.com; m...@redhat.com; Stefan Hajnoczi; > mtosa...@redhat.com; qemu-devel@nongnu.org; arm...@redhat.com; > av1...@comtv.ru; Tomoki Sekiyama; pbonz...@redhat.com; > lcapitul...@redhat.com; Seiji Aguchi > Subject: Re: [Qemu-devel] [RFC][PATCH v2]Add timestamp to

Re: [Qemu-devel] [RFC][PATCH v2]Add timestamp to error message

2013-05-01 Thread Anthony Liguori
"Daniel P. Berrange" writes: > On Wed, May 01, 2013 at 06:16:33AM -0600, Eric Blake wrote: >> On 05/01/2013 06:05 AM, Stefan Hajnoczi wrote: >> >> >> +error_printf( >> >> + "%4d-%02d-%02d %02d:%02d:%02d.%03lld+ ", >> >> + fields.tm_year + 1900, fields.tm_mon + 1, fiel

Re: [Qemu-devel] [RFC][PATCH v2]Add timestamp to error message

2013-05-01 Thread Daniel P. Berrange
On Wed, May 01, 2013 at 06:16:33AM -0600, Eric Blake wrote: > On 05/01/2013 06:05 AM, Stefan Hajnoczi wrote: > > >> +error_printf( > >> + "%4d-%02d-%02d %02d:%02d:%02d.%03lld+ ", > >> + fields.tm_year + 1900, fields.tm_mon + 1, fields.tm_mday, > >> + fields.tm

Re: [Qemu-devel] [RFC][PATCH v2]Add timestamp to error message

2013-05-01 Thread Eric Blake
On 05/01/2013 06:05 AM, Stefan Hajnoczi wrote: >> +error_printf( >> + "%4d-%02d-%02d %02d:%02d:%02d.%03lld+ ", >> + fields.tm_year + 1900, fields.tm_mon + 1, fields.tm_mday, >> + fields.tm_hour, fields.tm_min, fields.tm_sec, >> + now % 1000); > > Ca

Re: [Qemu-devel] [RFC][PATCH v2]Add timestamp to error message

2013-05-01 Thread Stefan Hajnoczi
On Mon, Apr 29, 2013 at 03:57:25PM -0400, Seiji Aguchi wrote: > diff --git a/util/qemu-error.c b/util/qemu-error.c > index 08a36f4..35ef9ab 100644 > --- a/util/qemu-error.c > +++ b/util/qemu-error.c > @@ -196,6 +196,96 @@ void error_print_loc(void) > } > } > > + > +#define SECS_PER_HOUR (

[Qemu-devel] [RFC][PATCH v2]Add timestamp to error message

2013-04-29 Thread Seiji Aguchi
From: Seiji Aguchi [Issue] When we offer a customer support service and a problem happens in a customer's system, we try to understand the problem by comparing what the customer reports with message logs of the customer's system. In this case, we often need to know when the problem happens.