Re: [Qemu-devel] [RFC][PATCH 6/7] blkdebug: Add events and rules

2010-03-29 Thread Kevin Wolf
Am 28.03.2010 15:12, schrieb Christoph Hellwig: > On Mon, Mar 15, 2010 at 06:08:34PM +0100, Kevin Wolf wrote: >> +fprintf(stderr, "bdrv_debug_event: %d\n", event); > > Is this supposed to be in the final version or a leftover debugging aid? It's not there in the final version (which I have al

Re: [Qemu-devel] [RFC][PATCH 6/7] blkdebug: Add events and rules

2010-03-28 Thread Christoph Hellwig
On Mon, Mar 15, 2010 at 06:08:34PM +0100, Kevin Wolf wrote: > +fprintf(stderr, "bdrv_debug_event: %d\n", event); Is this supposed to be in the final version or a leftover debugging aid? > +#define BLKDBG_EVENT(bs, evt) bdrv_debug_event(bs, evt) Why not call bdrv_debug_event directly? > +

[Qemu-devel] [RFC][PATCH 6/7] blkdebug: Add events and rules

2010-03-15 Thread Kevin Wolf
Block drivers can trigger a blkdebug event whenever they reach a place where it could be useful to inject an error for testing/debugging purposes. Rules are read from a blkdebug config file and describe which action is taken when an event is triggered. For now this is only injecting an error (with