Re: [Qemu-devel] [RFC][PATCH 08/16 v6] target-i386: add API to get dump info

2012-02-15 Thread Jan Kiszka
On 2012-02-15 04:30, Wen Congyang wrote: >>> diff --git a/dump.h b/dump.h >>> new file mode 100644 >>> index 000..a36468b >>> --- /dev/null >>> +++ b/dump.h >>> @@ -0,0 +1,10 @@ >> >> License header missing. > > There is no license in other header files. But those are preexisting files, no ne

Re: [Qemu-devel] [RFC][PATCH 08/16 v6] target-i386: add API to get dump info

2012-02-15 Thread Wen Congyang
At 02/15/2012 05:12 PM, Peter Maydell Wrote: > On 9 February 2012 03:26, Wen Congyang wrote: >> +int cpu_get_dump_info(ArchDumpInfo *info) >> +{ >> +bool lma = false; >> +RAMBlock *block; >> + >> +#ifdef TARGET_X86_64 >> +lma = !!(first_cpu->hflags & HF_LMA_MASK); >> +#endif >> + >> +

Re: [Qemu-devel] [RFC][PATCH 08/16 v6] target-i386: add API to get dump info

2012-02-15 Thread Peter Maydell
On 9 February 2012 03:26, Wen Congyang wrote: > +int cpu_get_dump_info(ArchDumpInfo *info) > +{ > +    bool lma = false; > +    RAMBlock *block; > + > +#ifdef TARGET_X86_64 > +    lma = !!(first_cpu->hflags & HF_LMA_MASK); > +#endif > + > +    if (lma) { > +        info->d_machine = EM_X86_64; > +

Re: [Qemu-devel] [RFC][PATCH 08/16 v6] target-i386: add API to get dump info

2012-02-15 Thread Wen Congyang
At 02/15/2012 05:05 PM, Jan Kiszka Wrote: > On 2012-02-15 04:30, Wen Congyang wrote: diff --git a/dump.h b/dump.h new file mode 100644 index 000..a36468b --- /dev/null +++ b/dump.h @@ -0,0 +1,10 @@ >>> >>> License header missing. >> >> There is no license in other

Re: [Qemu-devel] [RFC][PATCH 08/16 v6] target-i386: add API to get dump info

2012-02-14 Thread Wen Congyang
At 02/15/2012 01:39 AM, Jan Kiszka Wrote: > On 2012-02-09 04:26, Wen Congyang wrote: >> Dump info contains: endian, class and architecture. The next >> patch will use these information to create vmcore. >> >> Signed-off-by: Wen Congyang >> --- >> cpu-all.h |3 +++ >> dump.h

Re: [Qemu-devel] [RFC][PATCH 08/16 v6] target-i386: add API to get dump info

2012-02-14 Thread Jan Kiszka
On 2012-02-09 04:26, Wen Congyang wrote: > Dump info contains: endian, class and architecture. The next > patch will use these information to create vmcore. > > Signed-off-by: Wen Congyang > --- > cpu-all.h |3 +++ > dump.h | 10 ++ > target-i386/arch

[Qemu-devel] [RFC][PATCH 08/16 v6] target-i386: add API to get dump info

2012-02-08 Thread Wen Congyang
Dump info contains: endian, class and architecture. The next patch will use these information to create vmcore. Signed-off-by: Wen Congyang --- cpu-all.h |3 +++ dump.h | 10 ++ target-i386/arch-dump.c | 34 ++ 3 file