Re: [Qemu-devel] [RFC/RFT PATCH] build: replace weak symbols with a static library

2012-11-16 Thread Peter Maydell
On 16 November 2012 17:06, Peter Maydell wrote: > This turns out to be the same problem as the MacOS failure: > as well as building the libqemustub.a in the root directory > we also try to create an empty libqemustub.a in arm-softmmu/ > (or whatever the target subdir is). On MacOS this fails > bec

Re: [Qemu-devel] [RFC/RFT PATCH] build: replace weak symbols with a static library

2012-11-16 Thread Peter Maydell
On 16 November 2012 16:54, Peter Maydell wrote: > And it doesn't build on Linux: Adding libqemustub.a to the vscclient$(EXESUF) prerequisites fixes that, and then it fails on qemu-system-arm: LINK arm-softmmu/qemu-system-arm ../qmp.o: In function `qmp_query_cpu_definitions': /home/petmay01/li

Re: [Qemu-devel] [RFC/RFT PATCH] build: replace weak symbols with a static library

2012-11-16 Thread Peter Maydell
On 16 November 2012 15:50, Paolo Bonzini wrote: > Weak symbols were a nice idea, but they turned out not to be > a good one. Toolchain support is just too sparse. > > This patch uses a surprisingly low-tech approach, i.e. static > libraries. Symbols in a static library are always overridden > by

[Qemu-devel] [RFC/RFT PATCH] build: replace weak symbols with a static library

2012-11-16 Thread Paolo Bonzini
Weak symbols were a nice idea, but they turned out not to be a good one. Toolchain support is just too sparse. This patch uses a surprisingly low-tech approach, i.e. static libraries. Symbols in a static library are always overridden by symbols in an object file. Furthermore, if you place each