Re: [Qemu-devel] [RESEND-try-2][PATCH] hw/9pfs: fix P9_STATS_GEN handling

2014-01-07 Thread Markus Armbruster
"Kirill A. Shutemov" writes: > Aneesh Kumar K.V wrote: >> "Kirill A. Shutemov" writes: >> >> > Kirill A. Shutemov wrote: >> >> Currently we have few issues with P9_STATS_GEN: >> >> >> >> - We don't try to read st_gen anything except files or directories, but >> >>still set P9_STATS_GEN bi

Re: [Qemu-devel] [RESEND-try-2][PATCH] hw/9pfs: fix P9_STATS_GEN handling

2013-12-23 Thread Kirill A. Shutemov
Aneesh Kumar K.V wrote: > "Kirill A. Shutemov" writes: > > > Kirill A. Shutemov wrote: > >> Currently we have few issues with P9_STATS_GEN: > >> > >> - We don't try to read st_gen anything except files or directories, but > >>still set P9_STATS_GEN bit in st_result_mask. It may mislead clie

Re: [Qemu-devel] [RESEND-try-2][PATCH] hw/9pfs: fix P9_STATS_GEN handling

2013-12-09 Thread Aneesh Kumar K.V
"Kirill A. Shutemov" writes: > Kirill A. Shutemov wrote: >> Currently we have few issues with P9_STATS_GEN: >> >> - We don't try to read st_gen anything except files or directories, but >>still set P9_STATS_GEN bit in st_result_mask. It may mislead client: >>we present garbage as valid

Re: [Qemu-devel] [RESEND-try-2][PATCH] hw/9pfs: fix P9_STATS_GEN handling

2013-12-09 Thread Kirill A. Shutemov
Kirill A. Shutemov wrote: > Currently we have few issues with P9_STATS_GEN: > > - We don't try to read st_gen anything except files or directories, but >still set P9_STATS_GEN bit in st_result_mask. It may mislead client: >we present garbage as valid st_gen. > > - If we failed to get va

[Qemu-devel] [RESEND-try-2][PATCH] hw/9pfs: fix P9_STATS_GEN handling

2013-11-29 Thread Kirill A. Shutemov
Currently we have few issues with P9_STATS_GEN: - We don't try to read st_gen anything except files or directories, but still set P9_STATS_GEN bit in st_result_mask. It may mislead client: we present garbage as valid st_gen. - If we failed to get valid st_gen with ENOTTY, we ignore error,