Re: [Qemu-devel] [Qemu devel V4 PATCH] msf2: Remove dead code reported by Coverity

2017-10-30 Thread Peter Maydell
On 25 October 2017 at 03:29, Subbaraya Sundeep wrote: > Fixed incorrect frame size mask, validated maximum frame > size in spi_write and removed dead code. > > Signed-off-by: Subbaraya Sundeep > --- > v4: > changed %d to %u while logging frame size error. > v3: > Added comment tha

Re: [Qemu-devel] [Qemu devel V4 PATCH] msf2: Remove dead code reported by Coverity

2017-10-26 Thread Alistair Francis
On Wed, Oct 25, 2017 at 4:29 AM, Subbaraya Sundeep wrote: > Fixed incorrect frame size mask, validated maximum frame > size in spi_write and removed dead code. > > Signed-off-by: Subbaraya Sundeep Reviewed-by: Alistair Francis > --- > v4: > changed %d to %u while logging frame size err

Re: [Qemu-devel] [Qemu devel V4 PATCH] msf2: Remove dead code reported by Coverity

2017-10-25 Thread sundeep subbaraya
On Wed, Oct 25, 2017 at 2:15 PM, Darren Kenny wrote: > LGTM now, thanks. > > Reviewed-by: Darren Kenny > Thanks Darren, Sundeep > > Thanks, > > Darren. > > > On Wed, Oct 25, 2017 at 07:59:04AM +0530, Subbaraya Sundeep wrote: > >> Fixed incorrect frame size mask, validated maximum frame >> siz

Re: [Qemu-devel] [Qemu devel V4 PATCH] msf2: Remove dead code reported by Coverity

2017-10-25 Thread Darren Kenny
LGTM now, thanks. Reviewed-by: Darren Kenny Thanks, Darren. On Wed, Oct 25, 2017 at 07:59:04AM +0530, Subbaraya Sundeep wrote: Fixed incorrect frame size mask, validated maximum frame size in spi_write and removed dead code. Signed-off-by: Subbaraya Sundeep --- v4: changed %d to %u

[Qemu-devel] [Qemu devel V4 PATCH] msf2: Remove dead code reported by Coverity

2017-10-24 Thread Subbaraya Sundeep
Fixed incorrect frame size mask, validated maximum frame size in spi_write and removed dead code. Signed-off-by: Subbaraya Sundeep --- v4: changed %d to %u while logging frame size error. v3: Added comment that [31:6] bits are reserved in R_SPI_DFSIZE register and logged i