Re: [Qemu-devel] [Qemu-trivial] patch: add delay= suboption to -display curses

2014-05-27 Thread Dave Mielke
[quoted lines by Gerd Hoffmann on 2014/05/27 at 11:09 +0200] >Which means exactly? They are not prepared to find data for more than >one key event in the buffer? Not exactly. The bad code is an attempt to do a nonblocking keyboard read in MS-DOS. It goes like this: 1) Peek the DOS keyboard buf

Re: [Qemu-devel] [Qemu-trivial] patch: add delay= suboption to -display curses

2014-05-27 Thread Laszlo Ersek
On 05/25/14 14:56, Dave Mielke wrote: > [quoted lines by Michael Tokarev on 2014/05/25 at 16:41 +0400] >> And provided this hasn't been a problem for so many years, > > Perhaps it hasn't been observed before because the curses UI may not have > that > many users. I myself must use it as, being

Re: [Qemu-devel] [Qemu-trivial] patch: add delay= suboption to -display curses

2014-05-27 Thread Gerd Hoffmann
On Di, 2014-05-27 at 04:15 -0400, Dave Mielke wrote: > [quoted lines by Gerd Hoffmann on 2014/05/27 at 07:44 +0200] > > >What exactly is the problem? > > At the user level, the keyboard appears to be dead. An inspection of the > udnerlying code reveals that the application itsllf is querying the

Re: [Qemu-devel] [Qemu-trivial] patch: add delay= suboption to -display curses

2014-05-27 Thread Dave Mielke
[quoted lines by Gerd Hoffmann on 2014/05/27 at 07:44 +0200] >What exactly is the problem? At the user level, the keyboard appears to be dead. An inspection of the udnerlying code reveals that the application itsllf is querying the MS-DOS keyboard input buffer in a bad way. Those apps can't be

Re: [Qemu-devel] [Qemu-trivial] patch: add delay= suboption to -display curses

2014-05-26 Thread Gerd Hoffmann
On Mo, 2014-05-26 at 11:19 -0400, Dave Mielke wrote: > [quoted lines by Gerd Hoffmann on 2014/05/26 at 15:38 +0200] > > >Tried to make the curses ui a bit more clever? You could try caching > >the modifier state, then send only the changes. That gets the number of > >events down to 6 max (4 to u

Re: [Qemu-devel] [Qemu-trivial] patch: add delay= suboption to -display curses

2014-05-26 Thread Dave Mielke
[quoted lines by Gerd Hoffmann on 2014/05/26 at 15:38 +0200] >Tried to make the curses ui a bit more clever? You could try caching >the modifier state, then send only the changes. That gets the number of >events down to 6 max (4 to update modifier state, 2 for the actual key). Yes, except that,

Re: [Qemu-devel] [Qemu-trivial] patch: add delay= suboption to -display curses

2014-05-25 Thread Dave Mielke
[quoted lines by Michael Tokarev on 2014/05/25 at 16:41 +0400] >In addition to what Peter said, I think this suboption is named poorly. >Maybe it can be named, say, kbddelay, or keydelay, or something like that. >Just "delay" may be interpreted as _video_ delay, ie, delay updating picture >for so

Re: [Qemu-devel] [Qemu-trivial] patch: add delay= suboption to -display curses

2014-05-25 Thread Michael Tokarev
25.05.2014 03:29, Dave Mielke wrote: > Add support for the "-display curses" option to accept suboptions (-display > curses[,option...), and add the "delay=" suboption. This suboption > causes a millisecond-based delay to be inserted in between key events so that In addition to what Peter said