Re: [Qemu-devel] [Qemu-trivial] [PATCH] qxl: Fix QXLRam initialisation.

2013-06-19 Thread Michael Tokarev
17.06.2013 20:38, Anthony PERARD wrote:> The qxl driver expect NULL for QXLRam.memory_configs, but this is never > initialized. Thanks, applied to the trivial patches queue. /mjt

Re: [Qemu-devel] [Qemu-trivial] [PATCH] qxl: Fix QXLRam initialisation.

2013-06-18 Thread Anthony PERARD
Hi, On 18/06/13 06:37, Gerd Hoffmann wrote: > IIRC xen has a debug mode where it fills memory with non-zero values > instead, for debugging / testing purposes, and this is where things blow up. > > So while the fix is clearly correct, the patch isn't as critical as it > initially looks like. Inde

Re: [Qemu-devel] [Qemu-trivial] [PATCH] qxl: Fix QXLRam initialisation.

2013-06-17 Thread Gerd Hoffmann
Hi, >> If memory is set to 0xc2c2.., it leads to a spice-critical error when >> trying to start qxl. > But maybe instead of doing it this way, we should just memset the > whole thing to 0, to avoid similar bugs in the future? Are there > any arches out there which have cpu_to_le32(0) != 0 ? O

Re: [Qemu-devel] [Qemu-trivial] [PATCH] qxl: Fix QXLRam initialisation.

2013-06-17 Thread Michael Tokarev
17.06.2013 20:38, Anthony PERARD wrote: > The qxl driver expect NULL for QXLRam.memory_configs, but this is never > initialized. > > If memory is set to 0xc2c2.., it leads to a spice-critical error when > trying to start qxl. This bug has been introduced by: commit 020af1c45fec664d5d4cf3b8e5117