Re: [Qemu-devel] [Qemu-trivial] [PATCH] pflash: Avoid warnings from coverity

2012-09-24 Thread Kevin Wolf
Am 24.09.2012 10:41, schrieb Markus Armbruster: > Kevin Wolf writes: > >> Am 22.09.2012 20:53, schrieb Stefan Weil: >>> Am 22.09.2012 18:29, schrieb Stefan Hajnoczi: On Wed, Sep 19, 2012 at 06:41:14PM +0200, Stefan Weil wrote: >>> [snip] > offset_end = (offset_end + 511) >> 9;

Re: [Qemu-devel] [Qemu-trivial] [PATCH] pflash: Avoid warnings from coverity

2012-09-24 Thread Markus Armbruster
Kevin Wolf writes: > Am 22.09.2012 20:53, schrieb Stefan Weil: >> Am 22.09.2012 18:29, schrieb Stefan Hajnoczi: >>> On Wed, Sep 19, 2012 at 06:41:14PM +0200, Stefan Weil wrote: >> [snip] offset_end = (offset_end + 511) >> 9; -bdrv_write(pfl->bs, offset, pfl->storage +

Re: [Qemu-devel] [Qemu-trivial] [PATCH] pflash: Avoid warnings from coverity

2012-09-24 Thread Kevin Wolf
Am 22.09.2012 20:53, schrieb Stefan Weil: > Am 22.09.2012 18:29, schrieb Stefan Hajnoczi: >> On Wed, Sep 19, 2012 at 06:41:14PM +0200, Stefan Weil wrote: > [snip] >>> offset_end = (offset_end + 511) >> 9; >>> -bdrv_write(pfl->bs, offset, pfl->storage + (offset << 9), >>> -

Re: [Qemu-devel] [Qemu-trivial] [PATCH] pflash: Avoid warnings from coverity

2012-09-22 Thread Stefan Weil
Am 22.09.2012 18:29, schrieb Stefan Hajnoczi: On Wed, Sep 19, 2012 at 06:41:14PM +0200, Stefan Weil wrote: [snip] offset_end = (offset_end + 511) >> 9; -bdrv_write(pfl->bs, offset, pfl->storage + (offset << 9), - offset_end - offset); +if (bdrv_write(

Re: [Qemu-devel] [Qemu-trivial] [PATCH] pflash: Avoid warnings from coverity

2012-09-22 Thread Peter Maydell
On 22 September 2012 17:29, Stefan Hajnoczi wrote: > Please report the errno and possibly bdrv_get_device_name() to uniquely > identify this block device. > > Peter's comments about reporting errors to the guest make sense to me. > I'm not sure how much work that involves, printing the error is a

Re: [Qemu-devel] [Qemu-trivial] [PATCH] pflash: Avoid warnings from coverity

2012-09-22 Thread Stefan Hajnoczi
On Wed, Sep 19, 2012 at 06:41:14PM +0200, Stefan Weil wrote: > hw/pflash_cfi01.c:209: > check_return: Calling function "bdrv_write" without checking return value (as > is done elsewhere 35 out of 37 times). > > hw/pflash_cfi02.c:144: > unterminated_default: The default case is not terminated by a