Re: [Qemu-devel] [Qemu-ppc] [PATCH v3] ppc: make idle_timer a per-cpu variable

2019-07-19 Thread Shivaprasad G Bhat
On 07/18/2019 09:47 PM, Greg Kurz wrote: On Thu, 18 Jul 2019 10:21:28 -0500 Shivaprasad G Bhat wrote: +PowerPCCPU *cpu = POWERPC_CPU(cs); + +timer_deinit(&cpu->idle_timer); As stated in the timer.h header file, timer_del() should always be called before timer_deinit(). With that fix

Re: [Qemu-devel] [Qemu-ppc] [PATCH v3] ppc: make idle_timer a per-cpu variable

2019-07-18 Thread Greg Kurz
On Thu, 18 Jul 2019 10:21:28 -0500 Shivaprasad G Bhat wrote: > The current code is broken for more than vcpu as > each thread would overwrite and there were memory leaks. > > Make it part of PowerPCCPU so that every thread has a > separate one. Avoid using the timer_new_ns which is > not the pre