Re: [Qemu-devel] [Qemu-ppc] [PATCH] ppc/e500_pci: Fix an array overflow issue

2011-09-27 Thread Scott Wood
On 09/27/2011 12:01 PM, Alexander Graf wrote: > > On 27.09.2011, at 18:52, Scott Wood wrote: > >> On 09/27/2011 07:45 AM, Alexander Graf wrote: >>> So this is the main change, right? Why the -1? A guest could potentially >>> access pib[-1] using this, no? >> >> Not with the values of addr that l

Re: [Qemu-devel] [Qemu-ppc] [PATCH] ppc/e500_pci: Fix an array overflow issue

2011-09-27 Thread Alexander Graf
On 27.09.2011, at 19:04, Richard Henderson wrote: > On 09/27/2011 10:01 AM, Alexander Graf wrote: >> 0xd >> 0xe >> 0xf >> >> ... and & 0x3 them >> >> 0x1 >> 0x2 >> 0x0 > > That's a remarkably different AND function... No, it's a typo. I typed % instead of & and didn't realize it. Bleks.

Re: [Qemu-devel] [Qemu-ppc] [PATCH] ppc/e500_pci: Fix an array overflow issue

2011-09-27 Thread Richard Henderson
On 09/27/2011 10:01 AM, Alexander Graf wrote: > 0xd > 0xe > 0xf > > ... and & 0x3 them > > 0x1 > 0x2 > 0x0 That's a remarkably different AND function... r~

Re: [Qemu-devel] [Qemu-ppc] [PATCH] ppc/e500_pci: Fix an array overflow issue

2011-09-27 Thread Alexander Graf
On 27.09.2011, at 18:52, Scott Wood wrote: > On 09/27/2011 07:45 AM, Alexander Graf wrote: >> On 27.09.2011, at 10:17, Liu Yu wrote: >>> --- >>> hw/ppce500_pci.c | 26 -- >>> 1 files changed, 16 insertions(+), 10 deletions(-) >>> >>> diff --git a/hw/ppce500_pci.c b/hw/pp

Re: [Qemu-devel] [Qemu-ppc] [PATCH] ppc/e500_pci: Fix an array overflow issue

2011-09-27 Thread Scott Wood
On 09/27/2011 07:45 AM, Alexander Graf wrote: > On 27.09.2011, at 10:17, Liu Yu wrote: >> --- >> hw/ppce500_pci.c | 26 -- >> 1 files changed, 16 insertions(+), 10 deletions(-) >> >> diff --git a/hw/ppce500_pci.c b/hw/ppce500_pci.c >> index 2db365d..3e24e85 100644 >> --- a/