Re: [Qemu-devel] [Qemu-ppc] [PATCH] adb: change handler only when recognized

2016-08-09 Thread Howard Spoelstra
On Tue, Aug 9, 2016 at 6:06 AM, Benjamin Herrenschmidt < b...@kernel.crashing.org> wrote: > On Tue, 2016-08-09 at 03:31 +0200, BALATON Zoltan wrote: > > > > > Because PowerBooks do (or rather a PMU-simulation of ADB) and MacOS > > > doesn't care. If ADB is in the device-tree, it will use it. It ma

Re: [Qemu-devel] [Qemu-ppc] [PATCH] adb: change handler only when recognized

2016-08-09 Thread Benjamin Herrenschmidt
On Tue, 2016-08-09 at 12:26 +0200, BALATON Zoltan wrote: > On Tue, 9 Aug 2016, Howard Spoelstra wrote: > > > > Openbios has problems with the USB keyboard when one specifically defines > > e.g., -device ich9-usb-uhci1,id=newusb -device usb-mouse,bus=newusb.0 > > (which is needed to get mouse/keybo

Re: [Qemu-devel] [Qemu-ppc] [PATCH] adb: change handler only when recognized

2016-08-09 Thread BALATON Zoltan
On Tue, 9 Aug 2016, Howard Spoelstra wrote: Openbios has problems with the USB keyboard when one specifically defines e.g., -device ich9-usb-uhci1,id=newusb -device usb-mouse,bus=newusb.0 (which is needed to get mouse/keyboard going in OSX 10.5) I think it does not have a UHCI driver, only mini

Re: [Qemu-devel] [Qemu-ppc] [PATCH] adb: change handler only when recognized

2016-08-08 Thread Benjamin Herrenschmidt
On Tue, 2016-08-09 at 03:31 +0200, BALATON Zoltan wrote: > > > Because PowerBooks do (or rather a PMU-simulation of ADB) and MacOS > > doesn't care. If ADB is in the device-tree, it will use it. It makes > > things easier to support multiple combinations especially when > > "comparing" things for

Re: [Qemu-devel] [Qemu-ppc] [PATCH] adb: change handler only when recognized

2016-08-08 Thread BALATON Zoltan
On Tue, 9 Aug 2016, Benjamin Herrenschmidt wrote: On Tue, 2016-08-09 at 02:11 +0200, BALATON Zoltan wrote: I don't know much about this but I've read here  that there are three  different kind of chips: CUDA, PMU99 and PMU. Confusingly both PM

Re: [Qemu-devel] [Qemu-ppc] [PATCH] adb: change handler only when recognized

2016-08-08 Thread Benjamin Herrenschmidt
On Tue, 2016-08-09 at 02:11 +0200, BALATON Zoltan wrote: > I don't know much about this but I've read here  > > that there are three  > different kind of chips: CUDA, PMU99 and PMU. Confusingly both PMU-s are  > > called via-pmu by Apple. And ther

Re: [Qemu-devel] [Qemu-ppc] [PATCH] adb: change handler only when recognized

2016-08-08 Thread BALATON Zoltan
On Tue, 9 Aug 2016, Benjamin Herrenschmidt wrote: On Sat, 2016-03-12 at 14:38 +0100, Hervé Poussineau wrote: ADB devices must take new handler into account only when they recognize it. This lets operating systems probe for valid/invalid handles, to know device capabilities. Add a FIXME in keybo

Re: [Qemu-devel] [Qemu-ppc] [PATCH] adb: change handler only when recognized

2016-08-08 Thread Benjamin Herrenschmidt
On Sat, 2016-03-12 at 14:38 +0100, Hervé Poussineau wrote: > ADB devices must take new handler into account only when they > recognize it. > This lets operating systems probe for valid/invalid handles, to know > device capabilities. > > Add a FIXME in keyboard handler, which should use a different