Re: [Qemu-devel] [Qemu-ppc] [PATCH v7 1/3] Add USB option in machine options

2012-08-15 Thread Li Zhang
On Wed, Aug 15, 2012 at 7:13 PM, David Gibson wrote: > On Wed, Aug 15, 2012 at 01:44:28PM +0800, Li Zhang wrote: >> On Wed, Aug 15, 2012 at 10:57 AM, David Gibson wrote: >> > On Wed, Aug 15, 2012 at 10:50:04AM +0800, Li Zhang wrote: >> >> On Wed, Aug 15, 2012 at 9:47 AM, David Gibson wrote: >> >

Re: [Qemu-devel] [Qemu-ppc] [PATCH v7 1/3] Add USB option in machine options

2012-08-15 Thread David Gibson
On Wed, Aug 15, 2012 at 01:44:28PM +0800, Li Zhang wrote: > On Wed, Aug 15, 2012 at 10:57 AM, David Gibson wrote: > > On Wed, Aug 15, 2012 at 10:50:04AM +0800, Li Zhang wrote: > >> On Wed, Aug 15, 2012 at 9:47 AM, David Gibson wrote: > >> > On Wed, Aug 15, 2012 at 09:24:34AM +0800, Li Zhang wrote

Re: [Qemu-devel] [Qemu-ppc] [PATCH v7 1/3] Add USB option in machine options

2012-08-14 Thread Li Zhang
On Wed, Aug 15, 2012 at 10:57 AM, David Gibson wrote: > On Wed, Aug 15, 2012 at 10:50:04AM +0800, Li Zhang wrote: >> On Wed, Aug 15, 2012 at 9:47 AM, David Gibson wrote: >> > On Wed, Aug 15, 2012 at 09:24:34AM +0800, Li Zhang wrote: >> >> On Wed, Aug 15, 2012 at 8:09 AM, Benjamin Herrenschmidt >>

Re: [Qemu-devel] [Qemu-ppc] [PATCH v7 1/3] Add USB option in machine options

2012-08-14 Thread David Gibson
On Wed, Aug 15, 2012 at 10:50:04AM +0800, Li Zhang wrote: > On Wed, Aug 15, 2012 at 9:47 AM, David Gibson wrote: > > On Wed, Aug 15, 2012 at 09:24:34AM +0800, Li Zhang wrote: > >> On Wed, Aug 15, 2012 at 8:09 AM, Benjamin Herrenschmidt > >> wrote: > >> > On Wed, 2012-08-15 at 09:10 +1000, David G

Re: [Qemu-devel] [Qemu-ppc] [PATCH v7 1/3] Add USB option in machine options

2012-08-14 Thread Li Zhang
On Wed, Aug 15, 2012 at 9:47 AM, David Gibson wrote: > On Wed, Aug 15, 2012 at 09:24:34AM +0800, Li Zhang wrote: >> On Wed, Aug 15, 2012 at 8:09 AM, Benjamin Herrenschmidt >> wrote: >> > On Wed, 2012-08-15 at 09:10 +1000, David Gibson wrote: >> >> > I see. I will redo this patch. Send out it late

Re: [Qemu-devel] [Qemu-ppc] [PATCH v7 1/3] Add USB option in machine options

2012-08-14 Thread David Gibson
On Wed, Aug 15, 2012 at 09:24:34AM +0800, Li Zhang wrote: > On Wed, Aug 15, 2012 at 8:09 AM, Benjamin Herrenschmidt > wrote: > > On Wed, 2012-08-15 at 09:10 +1000, David Gibson wrote: > >> > I see. I will redo this patch. Send out it later. :) > >> > Thanks for your comments. > >> > >> When you do

Re: [Qemu-devel] [Qemu-ppc] [PATCH v7 1/3] Add USB option in machine options

2012-08-14 Thread Li Zhang
On Wed, Aug 15, 2012 at 8:09 AM, Benjamin Herrenschmidt wrote: > On Wed, 2012-08-15 at 09:10 +1000, David Gibson wrote: >> > I see. I will redo this patch. Send out it later. :) >> > Thanks for your comments. >> >> When you do that, please also change the default to make spapr _not_ >> have usb. >

Re: [Qemu-devel] [Qemu-ppc] [PATCH v7 1/3] Add USB option in machine options

2012-08-14 Thread Benjamin Herrenschmidt
On Wed, 2012-08-15 at 09:10 +1000, David Gibson wrote: > > I see. I will redo this patch. Send out it later. :) > > Thanks for your comments. > > When you do that, please also change the default to make spapr _not_ > have usb. FYI, I originally asked for USB as default ... however it looks like a

Re: [Qemu-devel] [Qemu-ppc] [PATCH v7 1/3] Add USB option in machine options

2012-08-14 Thread Alexander Graf
On 15.08.2012, at 01:10, David Gibson wrote: > On Tue, Aug 14, 2012 at 11:01:19PM +0800, Li Zhang wrote: >> On Tue, Aug 14, 2012 at 6:46 PM, Alexander Graf wrote: >>> On 08/07/2012 04:41 AM, Li Zhang wrote: When -usb option is used, global varible usb_enabled is set. And all the

Re: [Qemu-devel] [Qemu-ppc] [PATCH v7 1/3] Add USB option in machine options

2012-08-14 Thread David Gibson
On Tue, Aug 14, 2012 at 11:01:19PM +0800, Li Zhang wrote: > On Tue, Aug 14, 2012 at 6:46 PM, Alexander Graf wrote: > > On 08/07/2012 04:41 AM, Li Zhang wrote: > >> > >> When -usb option is used, global varible usb_enabled is set. > >> And all the plafrom will create one USB controller according >

Re: [Qemu-devel] [Qemu-ppc][PATCH v7 1/3] Add USB option in machine options

2012-08-14 Thread Li Zhang
On Tue, Aug 14, 2012 at 6:46 PM, Alexander Graf wrote: > On 08/07/2012 04:41 AM, Li Zhang wrote: >> >> When -usb option is used, global varible usb_enabled is set. >> And all the plafrom will create one USB controller according >> to this variable. In fact, global varibles make code hard >> to rea

Re: [Qemu-devel] [Qemu-ppc][PATCH v7 1/3] Add USB option in machine options

2012-08-14 Thread Li Zhang
On Tue, Aug 14, 2012 at 6:39 PM, Alexander Graf wrote: > On 08/07/2012 04:41 AM, Li Zhang wrote: >> >> When -usb option is used, global varible usb_enabled is set. >> And all the plafrom will create one USB controller according >> to this variable. In fact, global varibles make code hard >> to rea

Re: [Qemu-devel] [Qemu-ppc][PATCH v7 1/3] Add USB option in machine options

2012-08-14 Thread Alexander Graf
On 08/07/2012 04:41 AM, Li Zhang wrote: When -usb option is used, global varible usb_enabled is set. And all the plafrom will create one USB controller according to this variable. In fact, global varibles make code hard to read. So this patch is to remove global variable usb_enabled and add USB

Re: [Qemu-devel] [Qemu-ppc][PATCH v7 1/3] Add USB option in machine options

2012-08-14 Thread Alexander Graf
On 08/07/2012 04:41 AM, Li Zhang wrote: When -usb option is used, global varible usb_enabled is set. And all the plafrom will create one USB controller according to this variable. In fact, global varibles make code hard to read. So this patch is to remove global variable usb_enabled and add USB

[Qemu-devel] [Qemu-ppc][PATCH v7 1/3] Add USB option in machine options

2012-08-06 Thread Li Zhang
When -usb option is used, global varible usb_enabled is set. And all the plafrom will create one USB controller according to this variable. In fact, global varibles make code hard to read. So this patch is to remove global variable usb_enabled and add USB option in machine options. All the plaform