Re: [Qemu-devel] [Qemu-devel PATCH v2 1/2] sd: Fix out-of-bounds assertions

2019-06-06 Thread Philippe Mathieu-Daudé
Hi, On 6/5/19 9:15 PM, Lidong Chen wrote: > Due to an off-by-one error, the assert statements allow an > out-of-bound array access. I believe this is a "v2 RESEND" patch, since there is no change with the other v2 posted here: https://lists.gnu.org/archive/html/qemu-devel/2019-06/msg00634.html So

[Qemu-devel] [Qemu-devel PATCH v2 1/2] sd: Fix out-of-bounds assertions

2019-06-05 Thread Lidong Chen
Due to an off-by-one error, the assert statements allow an out-of-bound array access. Signed-off-by: Lidong Chen Reviewed-by: Liam Merwick Reviewed-by: Marc-André Lureau Reviewed-by: Philippe Mathieu-Daudé Reviewed-by: Li Qiang Reviewed-by: Darren Kenny --- hw/sd/sd.c | 4 ++-- 1 file chang

Re: [Qemu-devel] [Qemu-devel PATCH v2 1/2] sd: Fix out-of-bounds assertions

2019-06-05 Thread Philippe Mathieu-Daudé
On 6/5/19 8:21 AM, Lidong Chen wrote: > Due to an off-by-one error, the assert statements allow an > out-of-bound array access. Not sure via which tree this patch is going (trivial?). To the maintainer, please consider adding when applying: "This access can not happen. Fix to silent static analyz

[Qemu-devel] [Qemu-devel PATCH v2 1/2] sd: Fix out-of-bounds assertions

2019-06-04 Thread Lidong Chen
Due to an off-by-one error, the assert statements allow an out-of-bound array access. Signed-off-by: Lidong Chen Reviewed-by: Liam Merwick Reviewed-by: Marc-André Lureau Reviewed-by: Philippe Mathieu-Daudé Reviewed-by: Li Qiang Reviewed-by: Darren Kenny --- hw/sd/sd.c | 4 ++-- 1 file chang