Re: [Qemu-devel] [Qemu-block] [PATCH v3] qemu-img: add skip option to dd

2016-08-03 Thread Stefan Hajnoczi
On Thu, Jul 28, 2016 at 4:51 PM, Reda Sallahi wrote: > On 7/28/16, Stefan Hajnoczi wrote: >> On Wed, Jul 27, 2016 at 3:51 PM, Reda Sallahi wrote: >>> -qemu_opt_set_number(opts, BLOCK_OPT_SIZE, size, &error_abort); >>> +if (dd.flags & C_SKIP && size < in.bsz * in.offset) { >>> +er

Re: [Qemu-devel] [Qemu-block] [PATCH v3] qemu-img: add skip option to dd

2016-07-28 Thread Reda Sallahi
On 7/28/16, Stefan Hajnoczi wrote: > On Wed, Jul 27, 2016 at 3:51 PM, Reda Sallahi wrote: >> -qemu_opt_set_number(opts, BLOCK_OPT_SIZE, size, &error_abort); >> +if (dd.flags & C_SKIP && size < in.bsz * in.offset) { >> +error_report("%s: cannot skip to specified offset", >> in.file

Re: [Qemu-devel] [Qemu-block] [PATCH v3] qemu-img: add skip option to dd

2016-07-28 Thread Stefan Hajnoczi
On Wed, Jul 27, 2016 at 3:51 PM, Reda Sallahi wrote: > -qemu_opt_set_number(opts, BLOCK_OPT_SIZE, size, &error_abort); > +if (dd.flags & C_SKIP && size < in.bsz * in.offset) { > +error_report("%s: cannot skip to specified offset", in.filename); > +qemu_opt_set_number(opts,