Re: [Qemu-devel] [Qemu-block] [PATCH 4/7] vmdk: Reject invalid compressed writes

2019-08-13 Thread Max Reitz
On 12.08.19 23:16, John Snow wrote: > > > On 8/12/19 5:03 PM, Max Reitz wrote: >> On 12.08.19 22:26, John Snow wrote: >>> >>> >>> On 7/25/19 11:57 AM, Max Reitz wrote: Compressed writes generally have to write full clusters, not just in theory but also in practice when it comes to vmdk'

Re: [Qemu-devel] [Qemu-block] [PATCH 4/7] vmdk: Reject invalid compressed writes

2019-08-12 Thread John Snow
On 8/12/19 5:03 PM, Max Reitz wrote: > On 12.08.19 22:26, John Snow wrote: >> >> >> On 7/25/19 11:57 AM, Max Reitz wrote: >>> Compressed writes generally have to write full clusters, not just in >>> theory but also in practice when it comes to vmdk's streamOptimized >>> subformat. It currently

Re: [Qemu-devel] [Qemu-block] [PATCH 4/7] vmdk: Reject invalid compressed writes

2019-08-12 Thread Max Reitz
On 12.08.19 22:26, John Snow wrote: > > > On 7/25/19 11:57 AM, Max Reitz wrote: >> Compressed writes generally have to write full clusters, not just in >> theory but also in practice when it comes to vmdk's streamOptimized >> subformat. It currently is just silently broken for writes with >> non

Re: [Qemu-devel] [Qemu-block] [PATCH 4/7] vmdk: Reject invalid compressed writes

2019-08-12 Thread John Snow
On 7/25/19 11:57 AM, Max Reitz wrote: > Compressed writes generally have to write full clusters, not just in > theory but also in practice when it comes to vmdk's streamOptimized > subformat. It currently is just silently broken for writes with > non-zero in-cluster offsets: > > $ qemu-img cre