Re: [Qemu-devel] [Qemu-block] [PATCH 16/16] nvme: support multiple namespaces

2019-09-25 Thread Klaus Jensen
On Wed, Sep 25, 2019 at 11:33:45AM +, Paul Durrant wrote: > Hi Klaus, > > I may have missed something but are you planning a v2 of your > nvme_ns series soon? I just ran into another issue with this version > when trying to use non-consecutive nsid value; the code uses an > array of ns

RE: [Qemu-devel] [Qemu-block] [PATCH 16/16] nvme: support multiple namespaces

2019-09-25 Thread Paul Durrant
> -Original Message- > From: Klaus Jensen > Sent: 25 September 2019 13:15 > To: Paul Durrant > Cc: qemu-devel@nongnu.org; Paul Durrant > Subject: Re: [Qemu-devel] [Qemu-block] [PATCH 16/16] nvme: support multiple > namespaces > > On Wed, Sep 25, 2019 at 11:

Re: [Qemu-devel] [Qemu-block] [PATCH 16/16] nvme: support multiple namespaces

2019-09-25 Thread Paul Durrant
Hi Klaus, I may have missed something but are you planning a v2 of your nvme_ns series soon? I just ran into another issue with this version when trying to use non-consecutive nsid value; the code uses an array of ns indexed by the nsid, and using non-consecutive values causes it to wander of

Re: [Qemu-devel] [Qemu-block] [PATCH 16/16] nvme: support multiple namespaces

2019-07-05 Thread Daniel P . Berrangé
On Fri, Jul 05, 2019 at 06:20:14PM +0200, Klaus Birkelund wrote: > On Fri, Jul 05, 2019 at 02:49:29PM +0100, Daniel P. Berrangé wrote: > > On Fri, Jul 05, 2019 at 03:36:17PM +0200, Klaus Birkelund wrote: > > > On Fri, Jul 05, 2019 at 09:23:33AM +0200, Klaus Birkelund Jensen wrote: > > > > This adds

Re: [Qemu-devel] [Qemu-block] [PATCH 16/16] nvme: support multiple namespaces

2019-07-05 Thread Klaus Birkelund
On Fri, Jul 05, 2019 at 02:49:29PM +0100, Daniel P. Berrangé wrote: > On Fri, Jul 05, 2019 at 03:36:17PM +0200, Klaus Birkelund wrote: > > On Fri, Jul 05, 2019 at 09:23:33AM +0200, Klaus Birkelund Jensen wrote: > > > This adds support for multiple namespaces by introducing a new 'nvme-ns' > > > dev

Re: [Qemu-devel] [Qemu-block] [PATCH 16/16] nvme: support multiple namespaces

2019-07-05 Thread Daniel P . Berrangé
On Fri, Jul 05, 2019 at 03:36:17PM +0200, Klaus Birkelund wrote: > On Fri, Jul 05, 2019 at 09:23:33AM +0200, Klaus Birkelund Jensen wrote: > > This adds support for multiple namespaces by introducing a new 'nvme-ns' > > device model. The nvme device creates a bus named from the device name > > ('id

Re: [Qemu-devel] [Qemu-block] [PATCH 16/16] nvme: support multiple namespaces

2019-07-05 Thread Klaus Birkelund
On Fri, Jul 05, 2019 at 09:23:33AM +0200, Klaus Birkelund Jensen wrote: > This adds support for multiple namespaces by introducing a new 'nvme-ns' > device model. The nvme device creates a bus named from the device name > ('id'). The nvme-ns devices then connect to this and registers > themselves w