Re: [Qemu-devel] [Qemu-block] [PATCH 02/13] qcrypto-luks: misc refactoring

2019-08-22 Thread Maxim Levitsky
On Thu, 2019-08-22 at 12:10 +0100, Daniel P. Berrangé wrote: > On Thu, Aug 22, 2019 at 02:04:28PM +0300, Maxim Levitsky wrote: > > On Thu, 2019-08-22 at 11:29 +0100, Daniel P. Berrangé wrote: > > > On Thu, Aug 15, 2019 at 05:40:11PM -0400, John Snow wrote: > > > > > > > > > > > > On 8/14/19 4:22

Re: [Qemu-devel] [Qemu-block] [PATCH 02/13] qcrypto-luks: misc refactoring

2019-08-22 Thread Daniel P . Berrangé
On Thu, Aug 22, 2019 at 02:04:28PM +0300, Maxim Levitsky wrote: > On Thu, 2019-08-22 at 11:29 +0100, Daniel P. Berrangé wrote: > > On Thu, Aug 15, 2019 at 05:40:11PM -0400, John Snow wrote: > > > > > > > > > On 8/14/19 4:22 PM, Maxim Levitsky wrote: > > > > This is also a preparation for key read

Re: [Qemu-devel] [Qemu-block] [PATCH 02/13] qcrypto-luks: misc refactoring

2019-08-22 Thread Maxim Levitsky
On Thu, 2019-08-22 at 11:29 +0100, Daniel P. Berrangé wrote: > On Thu, Aug 15, 2019 at 05:40:11PM -0400, John Snow wrote: > > > > > > On 8/14/19 4:22 PM, Maxim Levitsky wrote: > > > This is also a preparation for key read/write/erase functions > > > > > > > This is a matter of taste and I am no

Re: [Qemu-devel] [Qemu-block] [PATCH 02/13] qcrypto-luks: misc refactoring

2019-08-22 Thread Daniel P . Berrangé
On Thu, Aug 15, 2019 at 05:40:11PM -0400, John Snow wrote: > > > On 8/14/19 4:22 PM, Maxim Levitsky wrote: > > This is also a preparation for key read/write/erase functions > > > > This is a matter of taste and I am not usually reviewing LUKS patches > (So don't take me too seriously), but I wo

Re: [Qemu-devel] [Qemu-block] [PATCH 02/13] qcrypto-luks: misc refactoring

2019-08-19 Thread Maxim Levitsky
On Thu, 2019-08-15 at 17:40 -0400, John Snow wrote: > > On 8/14/19 4:22 PM, Maxim Levitsky wrote: > > This is also a preparation for key read/write/erase functions > > > > This is a matter of taste and I am not usually reviewing LUKS patches > (So don't take me too seriously), but I would prefer

Re: [Qemu-devel] [Qemu-block] [PATCH 02/13] qcrypto-luks: misc refactoring

2019-08-15 Thread John Snow
On 8/14/19 4:22 PM, Maxim Levitsky wrote: > This is also a preparation for key read/write/erase functions > This is a matter of taste and I am not usually reviewing LUKS patches (So don't take me too seriously), but I would prefer not to have "misc" patches and instead split things out by indi