Re: [Qemu-devel] [Qemu-block] [PATCH] tcmu: Introduce qemu-tcmu utility

2019-03-12 Thread Fam Zheng
> On Mar 12, 2019, at 18:03, Kevin Wolf wrote: > > Am 12.03.2019 um 03:18 hat Fam Zheng geschrieben: >>> On Mar 11, 2019, at 19:06, Kevin Wolf wrote: >>> Am 09.03.2019 um 02:46 hat Yaowei Bai geschrieben: Thanks for explaining the background. It comes to my mind that actually we tal

Re: [Qemu-devel] [Qemu-block] [PATCH] tcmu: Introduce qemu-tcmu utility

2019-03-12 Thread Kevin Wolf
Am 12.03.2019 um 03:18 hat Fam Zheng geschrieben: > > On Mar 11, 2019, at 19:06, Kevin Wolf wrote: > > Am 09.03.2019 um 02:46 hat Yaowei Bai geschrieben: > >> Thanks for explaining the background. It comes to my mind that actually we > >> talked about these two cases with Fam a bit long time ago a

Re: [Qemu-devel] [Qemu-block] [PATCH] tcmu: Introduce qemu-tcmu utility

2019-03-11 Thread Fam Zheng
> On Mar 11, 2019, at 19:06, Kevin Wolf wrote: > > Am 09.03.2019 um 02:46 hat Yaowei Bai geschrieben: >> Thanks for explaining the background. It comes to my mind that actually we >> talked about these two cases with Fam a bit long time ago and decided to >> support both these two cases. The r

Re: [Qemu-devel] [Qemu-block] [PATCH] tcmu: Introduce qemu-tcmu utility

2019-03-11 Thread Kevin Wolf
Am 09.03.2019 um 02:46 hat Yaowei Bai geschrieben: > Thanks for explaining the background. It comes to my mind that actually we > talked about these two cases with Fam a bit long time ago and decided to > support both these two cases. The reason why we implement case2 first is > currently we care m

Re: [Qemu-devel] [Qemu-block] [PATCH] tcmu: Introduce qemu-tcmu utility

2019-03-11 Thread Stefan Hajnoczi
On Thu, Mar 07, 2019 at 11:34:55AM +0100, Kevin Wolf wrote: > Am 07.03.2019 um 11:22 hat Stefan Hajnoczi geschrieben: > > On Wed, Mar 06, 2019 at 10:56:33PM +0100, Kevin Wolf wrote: > > > Am 21.12.2018 um 11:16 hat Yaowei Bai geschrieben: > > > * The first priority should be adding an in-process is

Re: [Qemu-devel] [Qemu-block] [PATCH] tcmu: Introduce qemu-tcmu utility

2019-03-08 Thread Yaowei Bai
> > I'm not sure what check you mean. Case 2 would need to find an existing > export with the given name, of course, and would return an error if no > such export exists yet. > > But for care 1, isn't the image explicitly opened when the target is > configured? And if it can't be opened, -1 is re

Re: [Qemu-devel] [Qemu-block] [PATCH] tcmu: Introduce qemu-tcmu utility

2019-03-08 Thread Kevin Wolf
Am 08.03.2019 um 08:22 hat Yaowei Bai geschrieben: > > > > * The first priority should be adding an in-process iscsi target that > > > > can be managed with QMP, similar to the built-in NBD server. > > > > > > Well, people used to manage iscsi targets through targetcli, a command > > > line util

Re: [Qemu-devel] [Qemu-block] [PATCH] tcmu: Introduce qemu-tcmu utility

2019-03-07 Thread Yaowei Bai
> > > * The first priority should be adding an in-process iscsi target that > > > can be managed with QMP, similar to the built-in NBD server. > > > > Well, people used to manage iscsi targets through targetcli, a command > > line utility. Our intention is, with targetcli and qemu-tcmu, user can

Re: [Qemu-devel] [Qemu-block] [PATCH] tcmu: Introduce qemu-tcmu utility

2019-03-07 Thread Kevin Wolf
Am 07.03.2019 um 09:44 hat Yaowei Bai geschrieben: > Add Fam. > > On Wed, Mar 06, 2019 at 10:56:33PM +0100, Kevin Wolf wrote: > > Am 21.12.2018 um 11:16 hat Yaowei Bai geschrieben: > > > This patch introduces a new utility, qemu-tcmu. Apart from the > > > underlaying protocol it interacts with the

Re: [Qemu-devel] [Qemu-block] [PATCH] tcmu: Introduce qemu-tcmu utility

2019-03-07 Thread Kevin Wolf
Am 07.03.2019 um 11:22 hat Stefan Hajnoczi geschrieben: > On Wed, Mar 06, 2019 at 10:56:33PM +0100, Kevin Wolf wrote: > > Am 21.12.2018 um 11:16 hat Yaowei Bai geschrieben: > > * The first priority should be adding an in-process iscsi target that > > can be managed with QMP, similar to the built-

Re: [Qemu-devel] [Qemu-block] [PATCH] tcmu: Introduce qemu-tcmu utility

2019-03-07 Thread Stefan Hajnoczi
On Wed, Mar 06, 2019 at 10:56:33PM +0100, Kevin Wolf wrote: > Am 21.12.2018 um 11:16 hat Yaowei Bai geschrieben: > * The first priority should be adding an in-process iscsi target that > can be managed with QMP, similar to the built-in NBD server. Using the in-kernel SCSI target with TCMU, or do

Re: [Qemu-devel] [Qemu-block] [PATCH] tcmu: Introduce qemu-tcmu utility

2019-03-07 Thread Yaowei Bai
Add Fam. On Wed, Mar 06, 2019 at 10:56:33PM +0100, Kevin Wolf wrote: > Am 21.12.2018 um 11:16 hat Yaowei Bai geschrieben: > > This patch introduces a new utility, qemu-tcmu. Apart from the > > underlaying protocol it interacts with the world much like > > qemu-nbd. This patch bases on Fam's versio

Re: [Qemu-devel] [Qemu-block] [PATCH] tcmu: Introduce qemu-tcmu utility

2019-03-07 Thread Yaowei Bai
On Wed, Mar 06, 2019 at 10:56:33PM +0100, Kevin Wolf wrote: > Am 21.12.2018 um 11:16 hat Yaowei Bai geschrieben: > > This patch introduces a new utility, qemu-tcmu. Apart from the > > underlaying protocol it interacts with the world much like > > qemu-nbd. This patch bases on Fam's version. > > >

Re: [Qemu-devel] [Qemu-block] [PATCH] tcmu: Introduce qemu-tcmu utility

2019-03-06 Thread Kevin Wolf
Am 21.12.2018 um 11:16 hat Yaowei Bai geschrieben: > This patch introduces a new utility, qemu-tcmu. Apart from the > underlaying protocol it interacts with the world much like > qemu-nbd. This patch bases on Fam's version. > > Qemu-tcmu handles SCSI commands which are passed through userspace > f