Re: [Qemu-devel] [Qemu-block] [PATCH] block: use drained section in bdrv_close

2015-12-23 Thread Max Reitz
On 23.12.2015 22:55, Paolo Bonzini wrote: > >> On 23.12.2015 11:48, Paolo Bonzini wrote: >>> bdrv_close is used when ejecting a medium. >> >> Is it still? Other than it maybe being indirectly called through >> bdrv_delete(), it shouldn't be. > > Yes, through blk_remove_bs -> bdrv_unref -> bdrv_de

Re: [Qemu-devel] [Qemu-block] [PATCH] block: use drained section in bdrv_close

2015-12-23 Thread Paolo Bonzini
> On 23.12.2015 11:48, Paolo Bonzini wrote: > > bdrv_close is used when ejecting a medium. > > Is it still? Other than it maybe being indirectly called through > bdrv_delete(), it shouldn't be. Yes, through blk_remove_bs -> bdrv_unref -> bdrv_delete. > >

Re: [Qemu-devel] [Qemu-block] [PATCH] block: use drained section in bdrv_close

2015-12-23 Thread Max Reitz
On 23.12.2015 11:48, Paolo Bonzini wrote: > bdrv_close is used when ejecting a medium. Is it still? Other than it maybe being indirectly called through bdrv_delete(), it shouldn't be. > Use a drained section to ensure > that all I/O goes to either the o