Re: [Qemu-devel] [Qemu-block] [PATCH] block: modify top-id's comments

2016-09-30 Thread Stefan Hajnoczi
On Fri, Sep 30, 2016 at 11:48:44AM +0200, Kashyap Chamarthy wrote: > On Fri, Sep 30, 2016 at 04:53:38PM +0800, Wang WeiWei wrote: > > Kevin Wolf's advice: > > http://lists.gnu.org/archive/html/qemu-devel/2016-09/msg02391.html > > IIUC, what Stefan meant is to write a simple descriptive commit mess

Re: [Qemu-devel] [Qemu-block] [PATCH] block: modify top-id's comments

2016-09-30 Thread Kashyap Chamarthy
On Fri, Sep 30, 2016 at 04:53:38PM +0800, Wang WeiWei wrote: > Kevin Wolf's advice: > http://lists.gnu.org/archive/html/qemu-devel/2016-09/msg02391.html IIUC, what Stefan meant is to write a simple descriptive commit message that explains why this change is necessary -- the above URL might have co

Re: [Qemu-devel] [Qemu-block] [PATCH] block: modify top-id's comments

2016-09-30 Thread wangweiwei
Ok, I'wll wrap it. On 09/29/2016 09:35 PM, Eric Blake wrote: On 09/28/2016 05:31 AM, Stefan Hajnoczi wrote: On Wed, Sep 28, 2016 at 01:30:39PM +0800, Wang WeiWei wrote: Please send a proper commit message and commit description. "modify top-id's comments" says almost nothing and there is no co

Re: [Qemu-devel] [Qemu-block] [PATCH] block: modify top-id's comments

2016-09-29 Thread Eric Blake
On 09/28/2016 05:31 AM, Stefan Hajnoczi wrote: > On Wed, Sep 28, 2016 at 01:30:39PM +0800, Wang WeiWei wrote: > > Please send a proper commit message and commit description. "modify > top-id's comments" says almost nothing and there is no commit > description. I don't know why you are making thi

Re: [Qemu-devel] [Qemu-block] [PATCH] block: modify top-id's comments

2016-09-28 Thread Stefan Hajnoczi
On Wed, Sep 28, 2016 at 01:30:39PM +0800, Wang WeiWei wrote: Please send a proper commit message and commit description. "modify top-id's comments" says almost nothing and there is no commit description. I don't know why you are making this change so I can't review and apply it. > Signed-off-by